Comments (4)
An issue with wrapping requests automatically in a retry loop is that this may exacerbate any issues and potentially start triggering rate limiting by HubSpot. I think it's better for the user of the gem to decide for each request if they want to retry based on the failure type. If the failure is expressed as a specific exception class, these can easily be retried with existing functionality in things like ActiveJob or handled cleanly with Rails features like rescue_from
, or with a simple Ruby begin...end
with a retry
statement. This gives the user of the gem more flexibility to explicitly retry a failed request.
from hubspot-ruby.
Sticking with the language and community's idiomatic approach would have the smallest learning curve for folks looking to adopt this gem. Any thoughts on (optionally) wrapping requests in a retry if they hit a 4xx or 5xx (but not 429) error code?
from hubspot-ruby.
I think the main reason for using exceptions when working with external APIs is that since it's external you can rely on normal mechanisms for undoing something you've done. For example, with ActiveRecord, you may modify the properties of an instance and change several associated records as part of the change. If something fails, the SQL transaction can be rolled back and everything is undone. With an API that's not possible and it becomes an exceptional case.
I think there is a middle ground we can have here, which follows the Ruby (Rails?) conventions. Having an update()
method that returns false on error while also having an update!()
method that raises an exception on error.
from hubspot-ruby.
Thank you all for your feedback! I'm going to close this issue as I think we're in agreement on the following:
Design Decisions:
- Avoid leaky abstractions (ex: surfacing HTTParty responses or errors to the gem user)
- Include the Hubspot API error message when a request fails. We want to pass along all insight that's provided by the HubSpot API.
- The library will raise for any non-200 response
- Discuss “handling failure” on the README so readers know what to expect when a request fails and how best to rescue
from hubspot-ruby.
Related Issues (20)
- Support for Contact Update API HOT 1
- Saving a contact fails with "undefined method 'with_indifferent_access' for nil:NilClass (NoMethodError)" HOT 1
- Docs outdated? HOT 2
- ContactList Find Parses as Int HOT 1
- Question: Creating contact without email? HOT 2
- CompanyProperties doesn't work ?? HOT 2
- rubygems.org out of sync with linked repo HOT 1
- Status of this Project HOT 3
- Adding tickets
- Can't create new VCR cassettes using the demo hapikey HOT 2
- Pipelines and associations APIs are deprecated HOT 2
- Is it possible to batch create or update contacts? HOT 1
- Update Company Properties HOT 3
- Cant send property param in Contact Search HOT 2
- Get submissions of a form.
- Can this gem check the validity of an email address?
- Safe navigator for nil responses
- Hubspot::Config.reset! does not clear oauth headers
- Can we take over this gem ? HOT 1
- Authorization url is hardcoded - doesn't account for other data centers
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hubspot-ruby.