Comments (1)
This is something I ran into when I was implementing update
for both instances of Resource
and for the class level method. The API endpoints aren't consistent. I found some endpoints that will return only a success code, some that will return all the properties of the updated resource, and others that will return only the updated properties.
I've been thinking about the best path forward and I think one of the goals of the library is to provide an interface to the APIs that is consistent even if the API endpoints are not. So I'm thinking the lowest common denominator is likely what will have to be used here and assume that all endpoints only return a success code. From there we can merge in the changed properties. If the user wants the full property details including the updated history and other metadata associated with the property then they'll have to call reload
.
I hadn't realized this would also be broken with save and there aren't enough tests to cover all the new functionality yet so thank you for submitting a ticket. I'll take a look at this and will likely fix this as part of handling updates.
from hubspot-ruby.
Related Issues (20)
- Support for Contact Update API HOT 1
- Docs outdated? HOT 2
- ContactList Find Parses as Int HOT 1
- Question: Creating contact without email? HOT 2
- CompanyProperties doesn't work ?? HOT 2
- rubygems.org out of sync with linked repo HOT 1
- Status of this Project HOT 3
- Adding tickets
- Can't create new VCR cassettes using the demo hapikey HOT 2
- Pipelines and associations APIs are deprecated HOT 2
- Is it possible to batch create or update contacts? HOT 1
- Update Company Properties HOT 3
- Cant send property param in Contact Search HOT 2
- Get submissions of a form.
- Can this gem check the validity of an email address?
- Safe navigator for nil responses
- Hubspot::Config.reset! does not clear oauth headers
- Can we take over this gem ? HOT 1
- Authorization url is hardcoded - doesn't account for other data centers
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hubspot-ruby.