Code Monkey home page Code Monkey logo

Comments (1)

cbisnett avatar cbisnett commented on July 28, 2024

This is something I ran into when I was implementing update for both instances of Resource and for the class level method. The API endpoints aren't consistent. I found some endpoints that will return only a success code, some that will return all the properties of the updated resource, and others that will return only the updated properties.

I've been thinking about the best path forward and I think one of the goals of the library is to provide an interface to the APIs that is consistent even if the API endpoints are not. So I'm thinking the lowest common denominator is likely what will have to be used here and assume that all endpoints only return a success code. From there we can merge in the changed properties. If the user wants the full property details including the updated history and other metadata associated with the property then they'll have to call reload.

I hadn't realized this would also be broken with save and there aren't enough tests to cover all the new functionality yet so thank you for submitting a ticket. I'll take a look at this and will likely fix this as part of handling updates.

from hubspot-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.