Cannot use create_or_update! without passing email in properties about hubspot-ruby HOT 4 CLOSED

I suspect what you're seeing is a bug and is related to building the properties hash where we're only excluding the vid and not also the email (contact.rb:73).

My first though was that we should add :email to the except call and that would solve this problem but it would also mean that it wasn't possible to use bulk update to update email addresses when the vid is known. I'm not sure if updating the email address of a contact is supported when the identifier used is also an email address. This might explain the strange merging behavior you're seeing with email addresses.

Being able to change the email when using a vid seems like functionality we should maintain. We could change the except() call to exclude both :vid and :email and only merge the email into the properties hash when the identifier used is a vid. This way when creating or updating a contact using the email as the identifier, it won't try to also change the email address.

from hubspot-ruby.

Do you think something like this gets the behaviour we're looking for? Could refactor a bit to remove the duplication.

from hubspot-ruby.

To clean it up a little bit you could move the assignment of :vid or :email into the hash definition rather than merging on the next line. Something like this:

contact_param = {
  vid: contact_hash[:vid],
  properties: Hubspot::Utils.hash_to_properties(contact_hash.except(:vid))
}

from hubspot-ruby.

Sounds good. I'll clean it up and open a PR!

from hubspot-ruby.