hsynlms / fastify-guard Goto Github PK

FastifyError [Error]: fastify-plugin: fastify-guard - expected '3.x' fastify version, '4.2.0' is installed

In the README.md

This code doesn't work:

{ preHandler: [fastify.guard.role(['cto', 'admin'])] },

Instead it should be without []

{ preHandler: [fastify.guard.role('cto', 'admin')] },

When new PRs are sent, there is no CI mechanism to check changes and linter errors.

preHandler: [fastify.guard.role(['admin'])] -> In this way, preHandler is already called upon startup. And not on the route call.

Inside the preHandler function... fastify.guard.role(['admin']) don't work.

If you can correct me if I did something wrong.

"fastify": "^3.8.0"

For people who want to send PR.

We do not need environment-specific ignored files. Instead, only ignore project-specific things. Contributors need to ignore environment-specific things like .vscode, .DS_STORE etc, in their global gitignore file.

With the update of 1.3.0 my project has been broken.

With this declaration

role(roles: string | string[]): preHandlerHookHandler

Only allow

role('ADMIN') or role(['ADMIN','USER']);

Therefore this would not work

// this route can only be called by users who has 'admin' or 'editor' role
fastify.get(
  '/',
  { preHandler: [fastify.guard.role('admin', 'editor')] },
  (req, reply) => {
    // 'user' should already be defined in req object
    reply.send(req.user)
  }
)

To enable this functionality it should be:

role(...roles: string[]): preHandlerHookHandler
role(roles: string[]): preHandlerHookHandler

The same happens with the scope function

scope(scopes: string | string[]): preHandlerHookHandler