Object Pool and Asyncronous Pool

See: 4-improved.js

Signature poolify(factory, min, norm, max)

factory - call to instantiate pool item
min - minimum amount to allocate new
norm - preallocated amount
max - maximum amount to limit pool

pool's People

Contributors

Stargazers

Watchers

pool's Issues

Infinite loop with exclusive access

To reproduce

Pool from 9-exclusive.js up to b-timeout.js

const pool = new Pool();
pool.add({ item: 1 });
pool.add({ item: 2 });
let x1 = pool.capture();
const x2 = pool.capture();
pool.release(x1);
x1 = pool.capture();
pool.release(x1);
const bottom = pool.capture(); //infinite loop in next(1)

wrong release function in async example

  release(item) {
    const index = this.items.indexOf(item);
    if (index < 0) throw new Error('Pool: release unexpected item');
    if (this.free[index]) throw new Error('Pool: release not captured');
    this.free[index] = true;
    this.available++;
    if (this.queue.length > 0) {
      const { resolve, timer } = this.queue.shift();
      clearTimeout(timer);
      if (resolve) setTimeout(resolve, 0, item);
    }
  }

error - we should not free released item if we resolve it for user in queue

  release(item) {
    const index = this.items.indexOf(item);
    if (index < 0) throw new Error('Pool: release unexpected item');
    if (this.free[index]) throw new Error('Pool: release not captured');
    if (this.queue.length > 0) {
      const { resolve, timer } = this.queue.shift();
      clearTimeout(timer);
      if (resolve) setTimeout(resolve, 0, item);
    } else { 
      this.free[index] = true;
      this.available++;
    }
  }

Recommend Projects