housinghq / react-lazy-card Goto Github PK

Hi @bogas04 @azizhk , thanks for open-sourcing this component. I am wondering if you plan to extend this to lazy loading any component rather than just images?

Hello,

I think found a scenario

1. start to preload multiple images, preferable big ones
2. unmount the parent component

Warning: setState(...): Can only update a mounted or mounting component. This usually means you called setState() on an unmounted component. This is a no-op. Please check the code for the LazyCard component.

img.onload = function () { // 71 _this2.setState({ // 72 image: image // 73 }); // 74 };

I think the callback is not removed at unmount.

Hi,
I just noticed a small typo in the README file and I don't want to make a pull request for that...

https://github.com/housinghq/react-lazy-card#basic-usage --> JSX

<LazyCard image="b.jpg" autoLoad={true} defaultimage="default2.jpg">Text 2</LazyCard>

'defaultimage' is all written in lowercase, but the 'i' should be uppercase -> 'defaultImage'

Thanks for the plugin!