Migrated from rt.cpan.org #52325 (status was 'open')

Requestors:

• [email protected]
• [email protected]
• [email protected]

Attachments:

• File-ChangeNotify-movedto.diff

From [email protected] on 2009-12-01 16:42:39
:

Package: File-ChangeNotify-0.09
Perl: 5.10.0
os: Linux ubuntu 2.6.27-7-generic

In File::ChangeNotify::Watcher::Inotify sub __build__mask I believe that
IN_MOVED_TO should be included in $mask. Otherwise renaming/moving files
into a watched directory are not picked up.

Curtis Fletcher
Software Developer

tuscany networks Limited
Tuscany House, White Hart Lane, Basingstoke, RG21 4AF

Tel: 01256 303 726 Fax: 01256 303 701

www.tuscanynetworks.com

Important Notice
The information contained in or attached to this email is intended only for
the use of the correct addressee(s). If you are not the intended recipient,
or a person responsible for delivering it to the intended recipient, you are
not authorised to and must not disclose, copy, distribute, or retain this
message or any part of it.
It may contain information which is confidential and/or covered by legal
professional or other privilege (or other rules or laws with similar effect
in jurisdictions outside England and Wales). The views expressed in this
email are those of the author and not necessarily the views of the company,
its directors, officers or employees and we make no representation or accept
any liability for its accuracy or completeness unless expressly stated to
the contrary. The company will not be liable for direct, special, indirect
or consequential damages arising from alteration of the contents of this
message by a third party or as a result of any virus being passed on. The
company has implemented virus detection systems to minimise the risk of
passing on viruses. The company records all e-mail messages sent to and from
this address and reserves the right to monitor and examine content for the
purposes of training, quality control and for investigating or detecting any
unauthorised use of its system and for ensuring its effective operation.
tuscany networks is registered in England, company number 320 3561.

Migrated from rt.cpan.org #47814 (status was 'stalled')

Requestors:

• [email protected]

From [email protected] on 2009-07-12 20:39:38
:

On Debian Etch:

Linux xenoscience.net 2.6.24-etchnhalf.1-686 #1 SMP Mon Sep 8 06:19:11
UTC 2008 i686 GNU/Linux

CPAN installation gives:

Running make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e"
"test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/all.t ........... Could not load class
(File::ChangeNotify::Watcher::Inotify) because : Bareword
"IN_DONT_FOLLOW" not allowed while "strict subs" in use at
/home/krs/.cpan/build/File-ChangeNotify-0.07-fn9g3w/blib/lib/File/ChangeNotify/Watcher/Inotify.pm
line 109.
BEGIN not safe after errors--compilation aborted at
/home/krs/.cpan/build/File-ChangeNotify-0.07-fn9g3w/blib/lib/File/ChangeNotify/Watcher/Inotify.pm
line 192.
Compilation failed in require at /usr/local/lib/perl/5.8.8/Class/MOP.pm
line 134.
at /usr/local/lib/perl/5.8.8/Class/MOP.pm line 119
Class::MOP::load_first_existing_class('File::ChangeNotify::Watcher::Inotify') called at /usr/local/lib/perl/5.8.8/Class/MOP.pm line 140
Class::MOP::load_class('File::ChangeNotify::Watcher::Inotify') called
at
/home/krs/.cpan/build/File-ChangeNotify-0.07-fn9g3w/blib/lib/File/ChangeNotify.pm
line 38
eval {...} called at
/home/krs/.cpan/build/File-ChangeNotify-0.07-fn9g3w/blib/lib/File/ChangeNotify.pm
line 38
File::ChangeNotify::_try_load('File::ChangeNotify::Watcher::Inotify')
called at
/home/krs/.cpan/build/File-ChangeNotify-0.07-fn9g3w/blib/lib/File/ChangeNotify.pm
line 31
File::ChangeNotify::usable_classes('File::ChangeNotify') called at
t/lib/File/ChangeNotify/TestHelper.pm line 20
File::ChangeNotify::TestHelper::run_tests() called at t/all.t line 8
t/all.t ........... Dubious, test returned 9 (wstat 2304, 0x900)
No subtests run
t/kwalitee.t ...... skipped: This test is only run for the module author
t/pod-coverage.t .. skipped: This test is only run for the module author
t/pod.t ........... skipped: This test is only run for the module author

Test Summary Report

t/all.t (Wstat: 2304 Tests: 0 Failed: 0)
Non-zero exit status: 9
Parse errors: No plan found in TAP output
Files=4, Tests=0, 2 wallclock secs ( 0.12 usr 0.03 sys + 2.02 cusr
0.13 csys = 2.30 CPU)
Result: FAIL
Failed 1/4 test programs. 0/0 subtests failed.So, eventually I got this
to work with Linux::Inotify2 1.01 and
make: *** [test_dynamic] Error 255
DROLSKY/File-ChangeNotify-0.07.tar.gz
/usr/bin/make test -- NOT OK

Note that dependency Linux::Inotify2's Inotify.xs also would not compile
initially as it wanted to include '/usr/include/sys/inotify.h' which I
found in '/usr/include/linux/inotify.h'.

So, eventually I got this to work with Linux::Inotify2 1.01 and by
installing Debian package libinotifytools0-dev, then reinstalling your
module via CPAN.

So...figured you'd like to know it took some doing.
SSF

Migrated from rt.cpan.org #86719 (status was 'open')

Requestors:

• [email protected] (@sharyanto)

From [email protected] (@sharyanto) on 2013-07-05 04:21:35
:

If directory to watch is a symlink, currently it is not followed. It'd be nice if there is a warning about this, or a mention in the doc, or an option is added to resolve symlink.

Migrated from rt.cpan.org #109660 (status was 'open')

Requestors:

• [email protected]

From [email protected] on 2015-11-25 13:35:49
:

Hi there Mr Rolsky,

I have been using the File::ChangeNotify module in some recent work for
my employer.

I have tried using both File::ChangeNotify::Watcher::Default and
File::ChangeNotify::Watcher::Inotify. This problem affects both in a
sense, but is really an issue with File::ChangeNotify::Watcher::Inotify.

Some of the files I was working with were on the bulky side but not
humunguous - ca. 220MB. But I was finding that when I wrote code to
check the file size after the watcher had detected it, these files were
failing a validity tests that they should be over 66 lines. We came to
realise that the watcher was firing the code before its contents had
finished being copied.

Our lead dev figured out that the event you are picking up in
::Watcher::Inotify via Linux::Inotify2, IN_CREATE, was the issue. This
event gets fired at the beginning of file creation. Hence, before the
contents start being written.

I tried going back to just using ::Watcher::Default, but the same issues
were occurring there, too. Of course, this is unrelated to the inotify
event, as inotify is not involved.

In order to get the desired functionality, I simply replaced all
instances of 'IN_CREATE' in the ::Watcher::Inotify code with
'IN_CLOSE_WRITE'. (I also made some POD changes and renamed the changed
module). Now that I am watching for this event, I don't seem to be
having any more problems with large files appearing to have zero lines.

This should also address some of the issues mentioned in ticket #52325
regarding being able to run code at the end of a file transfer process.

However, IN_CLOSE_WRITE also gets triggered when an existing file is
overwritten, but not when renamed or moved. For my purposes, this was
appropriate. But it does stretch the concept of file creation a little.

Would you consider simply changing ::Watcher::Inotify to watch for this
event in place of IN_CREATE?

Thanks & regards,
Ludovic Tolhurst-Cleaver

Perl Engineer,
Inview Technology Ltd.,
Northwich, England.

Migrated from rt.cpan.org #82534 (status was 'open')

Requestors:

• [email protected] (@dakkar)

Attachments:

• build.log

From [email protected] (@dakkar) on 2013-01-07 11:17:56
:

http://cpantesters.org/cpan/report/4bec28d4-6bf7-1014-8bfa-8166d1d52598 makes me suspect that, under Win32, an event path may be reported with a forward slash instead of a back-slash.

The test is comparing a path created via Path::Class (which uses File::Spec internally) with a path returned from ChangeNotify. The former is C:\DOCUME~1\Admin\LOCALS~1\Temp\1R8WMye9O3\_queue_not_subscribed, the latter is C:\DOCUME~1\Admin\LOCALS~1\Temp\1R8WMye9O3/_queue_not_subscribed

If I get access to a Windows machine, I'll write a minimal test case, but getting access may take some time.