Code Monkey home page Code Monkey logo

browserclass's People

Contributors

hosszukalman avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

browserclass's Issues

IE8 and browserclass

If you comment the window.load event from the bottom of the browserclass file and use browserclass with jquerys document ready, IE8 says Object doesn't support this property or method on line 212, character 7.

$(function() {

BrowserClass.init();
// do something with the classes 
// example $('body').addClass(BrowserClass.classes.join(' '));   

}

Returning out of a function.

inside your checkPlatform and checkBrowser functions it would be much more performant to return out of the function when a match is found rather than carry on testing.

Mobile FF, Chrome and stock Android browser gets desktop class

Tried this with Samsung Galaxy S3 stock Android browser and Chrome. Alerted BrowserClass.classes.join(' ') => it says desktop

Same thing with HTC One S for Chrome, Firefox and stock Android browser

edit: added more devices
Safari IOS 6.1.6 also says desktop

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.