Unreadable "show images" buttons in Geary about arc-theme HOT 15 CLOSED

This is a common bug in webkitgtk (atleast I think it's webkitgtk). See here horst3180/vertex-theme#82 (comment)

The buttons use the color defined under .button:active, when in reality the button is not active :/

from arc-theme.

I'll have to close this, since it's not a bug in the theme. Maybe send a bug report to the geary devs.

from arc-theme.

Reported to geary development team.

https://bugzilla.gnome.org/show_bug.cgi?id=752312

from arc-theme.

Robert Schroll from yorba provided this
https://bugzilla.gnome.org/attachment.cgi?id=307367
Python script (downloadable from the bugtracker).

This shows basically two things: It's not a geary problem, but a webkit one. And as a matter of fact it does concern the theme.

Another place I've seen this problem is gnomes-bugtracker within epiphany-browser: the buttons show the exact same "white text".

This bug might need to be reopened?

from arc-theme.

The bug is only visible with themes which use a different text color for pressed buttons than for normal buttons.
For some reason webkit uses the color of pressed buttons to render normal buttons.

from arc-theme.

So. Is there a selector that lets you build a workaround for the webkit buttons until this is getting fixed in webkitgtk? It sadly brakes quite a lot of pages like webshops and I doubt that webkitgtk fixes are quick to get done.

from arc-theme.

There are no selectors to use unfortunately. The buttons use as color whatever is specified by .button:active.
I may have found a workaround, though. it should be possible to set the pushed button color like this:

.button:active {
    color: black;        /*Makes Webkit buttons readable*/
}

.button:active:hover,    /*Buttons that get pressed with the mouse*/
.button:checked {        /*Buttons that are toggled on*/
    color: white;
}

That would make the pressed webkit buttons and focused buttons, activated by the enter key, a little harder to read, since they have dark text on a blue background, but I think it's more usable than before.

from arc-theme.

This is what it looks like:

Normal

Pressed

from arc-theme.

Well, seeing text is an improvement, I agree. But isn't there any selector to get webkit-rendered buttons only? Stuff that can seriously be placed in a workarouds.css or something... because that's what this is, no?

https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Webkit_Extensions

Something that works within a gnome theme?

from arc-theme.

It looks like GTK only sees the WebKitWebView, the rest happens in webkit. Those webkit buttons are no actual GtkButtons I think. They just emulate the GTK look (badly).

from arc-theme.

That is most certainly true. I guess they are just plain old html buttons.

Now, the question is - it there a WebKitWebView > .button:active selector, that works within the webview but not outside of it - keeping potential uglyness away from the 'non-workaround-theme'?

from arc-theme.

I already tried that, it doesn't work. It doesn't work if I set the color for .button:active for the entire application, or for WebKitWebView * either.
The workaround I proposed is really my last resort.

from arc-theme.

Hm, ok. I'm currently browsing the webkitgtk bugtracker, to see if there is anything about the false :active flag.

from arc-theme.

Just a little report - I've been running your workaround for the last couple of hours. I haven't noticed any negative sideeffect beyond the black-text-when-clicking-the-button.

I have, however noticed a much improved workiness in epiphany-browser and geary.

It really is not a bug in the theme but in the way libwebkitgkt handles buttons and your workaround will improve it for the time being. /closed? (and similar ones?)

from arc-theme.

I agree. It's good enough until there's a proper fix in webkit.

from arc-theme.