Add Sidekiq support about honeybadger-ruby HOT 8 CLOSED

Heh. This is why we pay you the big bucks. :)

from honeybadger-ruby.

I'm on it, thanks!

from honeybadger-ruby.

Sidekiq 3.0 is now on master. You'll want to review this:

https://github.com/mperham/sidekiq/blob/master/Upgrading.md#error-service-providers

from honeybadger-ruby.

@mperham mind checking that commit (c3ac638)? I'll be doing some integration testing; we use Appraisals, but I have yet to find a good way to test against every combination of every gem we support. Is v3 stable enough for production yet?

from honeybadger-ruby.

@joshuap I think you might have a problem. The error handler isn't called until the error trickles all the way back up the stack to the Processor. By this time your middleware would have already executed and cleared the context. Maybe your error handler should clear the context after calling notify_or_ignore and skip the middleware?

from honeybadger-ruby.

I know of people already using 3.0 (aka the master branch) in production but we're not and I still think of master as not production quality yet. That said, I don't know of any problems with it.

from honeybadger-ruby.

Ah, good point. The problem with clearing the context in the error handler block is that it is only invoked when an error occurs, which would not be every job. Ideally the context would be specific to each job, since you wouldn't want data for multiple jobs being sent for a single exception. Can you think of a way to accomplish that? If not, I guess clearing it in the error handler would be better than nothing.

from honeybadger-ruby.

Clear it at the START of a new job. :-)

On Wed, Mar 12, 2014 at 8:16 AM, joshuap [email protected] wrote:

Ah, good point. The problem with clearing the context in the error handler
block is that it is only invoked when an error occurs, which would not be
every job. Ideally the context would be specific to each job, since you
wouldn't want data for multiple jobs being sent for a single exception. Can
you think of a way to accomplish that? If not, I guess clearing it in the
error handler would be better than nothing.

Reply to this email directly or view it on GitHubhttps://github.com//issues/63#issuecomment-37420387
.

from honeybadger-ruby.