Plugin loading limitation about honeybadger-ruby HOT 4 CLOSED

I am fine with renaming the methods in the plugin DSL to be clearer in theory, but I think it should be a separate consideration, and we'd want to consider if any 3rd parties are depending on the current method names.

I agree that it should be a separate change, if we do it, but I don't see much value in renaming the methods.

As for the load/unload strategy, is every plugin capable of being cleanly unloaded? For instance, the ones that do monkey patching and/or prepend modules?

This would be good to know... If the answer is no, then it seems the rest of this is moot.

Btw, not sure if it's helpful, but we also have a plain ruby mode which is another way to get around this issue (but you have to manually call Honeybadger.load_plugins!).

I didn't know this existed. :) It feels like this accomplishes the goal without having to make any code changes. :)

from honeybadger-ruby.

I am fine with renaming the methods in the plugin DSL to be clearer in theory, but I think it should be a separate consideration, and we'd want to consider if any 3rd parties are depending on the current method names.

As for the load/unload strategy, is every plugin capable of being cleanly unloaded? For instance, the ones that do monkey patching and/or prepend modules?

Btw, not sure if it's helpful, but we also have a plain ruby mode which is another way to get around this issue (but you have to manually call Honeybadger.load_plugins!).

cc @stympy

from honeybadger-ruby.

As for the load/unload strategy, is every plugin capable of being cleanly unloaded? For instance, the ones that do monkey patching and/or prepend modules?

I think, if we care about it, then yes. You can't remove a prepended module, but you can at least make its behaviour dynamic.

we also have a plain ruby mode which is another way to get around this issue

Yeah, but I think that moves a lot of the work to the user.

We could ignore all this for now, but the main blocker is the proposed logging feature outside of Rails apps. Since it's disabled by default, the user must enable it before plugins are loaded. But we can also go with one of these workarounds:

• support an env variable for this (eg HONEYBADGER_SEMANTIC_LOGGER_APPENDER).
• always load the plugin, and check the config setting dynamically on every usage.

from honeybadger-ruby.

Closing this since we don't need it for the logging bit right now and there's a workaround available.

from honeybadger-ruby.