Code Monkey home page Code Monkey logo

github-file-icons's People

Contributors

acharyarupak391 avatar arnellebalane avatar christopherpickering avatar ciffelia avatar coliff avatar csandman avatar dependabot[bot] avatar fregante avatar harmelodic avatar homerchen19 avatar jackymancs4 avatar kidonng avatar kiendang avatar koddsson avatar melonbreadvr avatar michieldx avatar sodatea avatar xxosirisxx77 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

github-file-icons's Issues

Location for adding missing file types

Is there a central file that contains all the supported file extensions with the link to their icon url. This would allow for people to easily add icons with a simple pr.

Feature Request: Enable on self-hosted GitLab

We are running a self-hosted internal GitLab instance, on a custom domain.
This extension only seems to apply to the hosted, public GitLab instance at gitlab.com.

It would be great if we'd be able to configure this extension to also cover our use case.

BUG: Dual icons when using back button

If you use the back button to go back to the file list (from a file or folder for example) the icons become duplicated. When you hover over them, this issue disappears. The issue reappears once you stop hovering.

Example

Swift icons should be orange

Currently, .swift files are represented by a green icon. However, the official Swift logo is the orange bird.
The exact color seems to be #DF5C43

screen shot 2018-01-08 at 22 18 52

Official Swift logo from swift.org:

Crashes on notifications page

I didn't find anything in my logs. These screenshots are from with and without the extension enabled.
Without extension
With extension

My extensions currently installed.

aeblfdkhhhdcdjpifhhbdiojplfjncoa : 1Password X โ€“ Password Manager : version 1_10_0
ahfgeienlihckogmohjhadlkjgocpleb : Web Store : version 0_2
aicmkgpgakddgnaphhhpliifpcfhicfo : Postman Interceptor : version 0_2_24
apdfllckaahabafndbhieahigkjlhalf : Google Drive : version 14_1
apnjnioapinblneaedefcnopcjepgkci : GitHub Repository Size : version 0_4_1
bcjindcccaagfpapjjmafapmmgkkhgoa : JSON Formatter : version 0_6_0
bhbekkddpbpbibiknkcjamlkhoghieie : Dark Night Mode : version 2_0_1
bknoejjhcfmakcibhifepfkegpjdnadk : Clear Downloads : version 1_0_0
blpcfgokakmgnkcojhhkbfbldkacnbeo : YouTube : version 4_2_8
bojgejgifofondahckoaahkilneffhmf : Chrome IG Story : version 2_2_3
cjpalhdlnbpafiamejdnhcphjbkeiagm : uBlock Origin : version 1_16_16
cnmciclhnghalnpfhhleggldniplelbg : Switcheroo Redirector : version 1_33
dhdgffkkebhmkfjojejmpbldmpobfkfo : Tampermonkey : version 4_6
eeocglpgjdpaefaedpblffpeebgmgddk : XV โ€” XML Viewer : version 1_1_6
ekpipjofdicppbepocohdlgenahaneen : Streamkeys : version 1_7_6
eljapbgkmlngdpckoiiibecpemleclhh : Fontface Ninja : version 4_0_1
fhbjgbiflinjbdggehcddcbncdddomop : Postman : version 5_5_3
ficfmibkjjnpogdcfhfokmihanoldbfe : File Icon for GitHub, GitLab and Bitbucket : version 0_6_1
fngmhnnpilhplaeedifhccceomclgfbg : EditThisCookie : version 1_4_7
gabdloknkpdefdpkkibplcfnkngbidim : delugesiphon : version 0_71_8
gcbommkclmclpchllfjekcdonpmejbdp : HTTPS Everywhere : version 2018_6_21
gdbofhhdmcladcmmfjolgndfkpobecpg : Don't track me Google : version 4_21
gfdkimpbcpahaombhbimeihdjnejgicl : Feedback : version 1_0
hgngncnljacgakaiifjcgdnknaglfipo : Google Search "View Image" Button : version 1_5
hhinaapppaileiechjoiifaancjggfjm : Web Scrobbler : version 2_6_0
hlepfoohegkhhmjieoechaddaejaokhf : Refined GitHub : version 18_8_4_1646
inobiceghmpkaklcknpniboilbjmlald : New XKit : version 7_8_2
iplffkdpngmdjhlpjmppncnlhomiipha : Unpaywall : version 3_77
kajibbejlbohfaggdiogboambcijhkke : Mailvelope : version 2_2_2
kbmfpngjjgdllneeigpgjifpgocmfgmb : Reddit Enhancement Suite : version 5_12_5
keefkhehidemnokodkdkejapdgfjmijf : Codecov Extension : version 1_0_9
klbibkeccnjlkjkiokjodocebajanakg : The Great Suspender : version 6_30
kmendfapggjehodndflmmgagdbamhnfd : CryptoTokenExtension : version 0_9_73
kneneiigihpjinpiaoidjolckmeaogdh : Moonlight Game Streaming : version 0_9_0
koljilikekcjfeecjefimopfffhkjbne : Vue Performance Devtool : version 0_0_6
lhdoppojpmngadmnindnejefpokejbdd : aXe : version 3_4_0_2
ljjemllljcmogpfapbkkighbhhppjdbg : Vue.js devtools : version 4_1_5_2
lpnakhpaodhdkleejaehlapdhbgjbddp : Hide Files on GitHub : version 2_1_0
mjcnijlhddpbdemagnpefmlkjdagkogk : Pocket : version 0_810
mpbelhhnfhfjnaehkcnnaknldmnocglk : HTML Validator : version 0_9_8_8
nbiddhncecgemgccalnoanpnenalmkic : GitHub Issue Link Status : version 18_6_14_2005
neajdppkdcdipfabeoofebfddakdcjhd : Google Network Speech : version 1_0
nfdfiepdkbnoanddpianalelglmfooik : Ears: Bass Boost, EQ Any Audio! : version 1_3_10
niloccemoadcdkdjlinkgdfekeahmflj : Save to Pocket : version 3_0_5_2
nkbihfbeogaeaoehlefnkodbefgpgknn : MetaMask : version 4_9_3
nmmhkkegccagdldgiimedpiccmgmieda : Chrome Web Store Payments : version 1_0_0_4
ognfafcpbkogffpmmdglhbjboeojlefj : Keybase : version 1_10_15
oiigbmnaadbkfbmpbfijlflahbdbdgdf : ScriptSafe : version 1_0_9_3
pcjnlebeogfamlbeloiccdidgmaeojhe : Quora Unblocker : version 1_0_3
pjkljhegncpnkpknbcohdijeoejaedia : Gmail : version 8_1
pkedcjkdefgpdelpbcmbmeomcjbeemfm : Chrome Media Router : version 6818_528_0_0
pkehgijcmpdhfbdbbnkijodmdjhbjlgp : Privacy Badger : version 2018_8_1
ppmmlchacdbknfphdeafcbmklcghghmd : JWT Debugger : version 3_0_0

Is there anything I can do to debug why this crashes?

Firefox: use $(ref:runtime.getURL)

Hi Homer,

Thank you for GitHub File Icons.
In Browser Console on current Firefox 92.0.1:

Error: Please use $(ref:runtime.getURL). 5 content.bundle.js:1
    <anonymous> moz-extension://55384411-0406-4198-b31e-a221ee4b2ef8/content.bundle.js:1

GitLab added another row

They added an item .., so currently the icon for ith item should have been the one for i - 1th. This issue only occur in sub-folder; there is no .. in project root folder.

Update Firefox Add-on to v1.0.0

The Chrome version of github-file-icon is on v1.0.0 and supports custom domains. But the Firefox add-on is currently on v0.8.1 (last updated Jan 29, 2019) which does not have the custom domains feature.

Are there plans for the Firefox add-on to be implemented?

Thanks for this extension, by the way. It's one of the few I love a lot.

Support for Gitea is broken

Currently the icons do not seem to work when self-hosting Gitea. Tested with Gitea Version: 1.11.0+dev-339-g54dab5a, github-file-icon v1.0.0 (fromt he chrome webstore) and Chromium Version 80.0.3977.0. (E.g. on this repo)

Question: Why settings in Popup menu?

Hello @xxhomey19
Only now I noted this change, introduced by 91fce31.

I was wondering if you can share the rationale behind your decision. It feels to me a little "wrong" to move settings from a place meant for settings to a place like the user popup, meant instad to provide high level interaction and to show off-page informations.

Given the static nature of the addon and the relatively low frequency of settings change I thing most users do, I think having one more action icon is a pretty much uneeded. Just a thought of mine.

Thanks.

Icon colors

Icons colors are sometimes not easy to see on dark themes of github ! i use a stylish css script to darken github but that's only a suggestion

use default cursor on icon

Hover on icon should keep cursor as default (typically an arrow) instead of cursor for text (a letter I).

Icons flashing issue

Icons will show briefly and disappear on initial page load.
They work as expect on refresh and with cached pages.

It seems they are being loaded then replaced by the default svg graphic.
Are others having this issue?

Feature request: View folder icons

Feature request:

Icon themes usually have special icons for folders like src,tests,.github.

I think it would be a great fit for this icon theme

Testing

Should have more unit test.

alignment issue for JSON file icon

screenshot 2018-06-03 pm 4 53 36

The โ€œdatabase iconโ€ is โ€œlefterโ€ than others. Itโ€™s not very obvious, so I enlarged the page for screenshot. Not sure whether it happens for any other types.

Ajax observer appears to be broken

The icons load, and stay, on a fresh page load, or a hard refresh / cached page load, but clicking into directory and triggering ajax results in a flash of icons then back to the generic icons.

Tested on Chrome 80.0.3987.106 (Official Build) (64-bit)

New Design: Async File infos -> icons get disabled

sometimes GitHub fetch the last commit info on top and for each file in an later call to the site - you know this when the info is gray (see Screenshots)

in that case when the fetched data is displayed the icons get lost and it shows only the previous white icons

Bildschirmfoto 2020-06-26 um 21 56 15

Note: in the screenshot you see the data loading before disappearing the icons

PS: this is hard to replay, an refresh not fetch new data. you have to open a new folder to get new data fetched. i guess the data is cached somewhere in the browser.

Folder icon is changed

Not sure if this is by design but some folders have their icon switched out like this:

image

To me, the .github/ folder in the screenshot should still have the folder icon but I could be alone in that opinion. Would you accept a PR to make sure we don't change the folder icons or at least provide the option to change the behaviour for people that would like to keep the folder icons intact?

Suggestion: replace in the repo and extensions names the 'Icon' to 'Icons'

Greetings

First of all, I like the extension a lot, thank you.

I'd like to make a suggestion:
replace in the repo and extensions names, the word 'Icon' to 'Icons' i.e.
the repo: github-file-icons
the Chrome extension: File Icons for GitHub and GitLab
the Firefox extension: File Icons for GitHub, GitLab and Bitbucket.

My reasoning is apparent: the extensions don't affect just 1 icon, but multiple icons (in repo file listings).

Thank you

Feature request: support dark themes

First: I love this extension!

I know the title is scary, but I propose a simplistic solution to make life better for dark GitHub users in a hurry. Here's what I'm doing locally:

.icon .octicon:before {
    filter: brightness(125%) contrast(150%) drop-shadow(0 0 0 #fff) drop-shadow(1px 1px 1px #444);
}

I'm sure a designer could do far better than I, but something like this rigged to a "Dark Mode" checkbox in the options would make it super simple for those with dark themes to have much better looking icons.

Here's a compare on my machine of extension+dark vs. extension+dark+tweak above:
compare

I think it's hard to tell in a 2:1 block up issue picture, but they're far more readable on a HiDPI screen. I'm not saying use my styling (though you're welcome to), but I just wanted to pitch the idea in general: a checkbox hooked to a CSS tweak to improve life a bit.

Thoughts?

Addon doesn't work on Github mobile layout

Nice Addon. Didn't knew I needed this until I saw it.
However I noticed it doesn't seem to work on my android phone using the mobile layout of Github (the desktop version works without problems)

Add ability to disable colors

I like the icons, but I don't like having that much color. Could you add an option that allows users to disable colors in the icons? Thank you!

Safari support?

It would be great ๐Ÿ‘ if there were a Safari version of it ๐Ÿ˜Š.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.