Change Request

Tell us about your environment

• Concourse version:
  v5.0.0
• github-webhook-resource version:
  v1.5.0

Describe your change request

The problem you want to solve:
Be able to configure webhook per organization in addition to webhook per repository

Your take on the correct solution to problem:

Do you plan to submit a pull request to implement this change?

Change Request

Tell us about your environment

• Concourse version: 7.8.2
• github-webhook-resource version: 1.2.0

Describe your change request

The problem you want to solve:
I do not want my pipeline to check the Github resource each time it is run. I run a multi branch workflow and have a "parent" pipeline that is responsible for creating and managing the child pipelines, and for cleaning up the third party resources that those child pipelines use (e.g. terraform resources). I would like the parent pipeline to also manage the Github webhooks.

Your take on the correct solution to problem:
Add an optional arguments for pipeline and instance_vars to the github webhook resource, which would then allow me to set the webhook url correctly for the child pipelines. We may also need a vars argument to be able to correctly construct the URL to the pipeline instance (as described by the Concourse docs for resource.webhook_token).

Do you plan to submit a pull request to implement this change?
No

Change Request

Tell us about your environment

• Concourse version: 7.4.1
• github-webhook-resource version: 1.1.5

Describe your change request

The problem you want to solve:
For pipelines using instances variables (instanced pipelines), this resource does not set up working webhooks. You need to append query params for each instance variable in the form of &var.some-var="someval".

Your take on the correct solution to problem:
Ideally the resource will automatically populate all instance variables in this way. An alternative is having a vars attribute that can be manually populated in the pipeline script; however, if any vars are forgotten in this manual way then I don't think the webhook will work.

Do you plan to submit a pull request to implement this change?
I may try if I can find the time to do so.

Describe your change request

It doesn't seem clear from the docs whether this is a resource to manage webhooks or to manage git via webhooks.

You should clarify. Is this used to create a resource on a pipeline which represents a git repo and is updated by a webhook which it creates, or is it for creating a webhook that is somehow used by a different resource?

In other words, it doesn't seem clear whether this is a resource that you can use to kick off a pipeline based on github or whether this is a tool for maintaining such things.