holonk / retail-calendar Goto Github PK

I expect that the enum LeapYearStrategy.DropFirstWeek drops the first week during 53 week years for comparison purposes.

In fact, this strategy drops the last week, and LeapYearStrategy.Restated drops the first week.

I have a need to provide a different leap year strategy to retail-calendar aside from restated or drop first week.

Naturally, it's hard to find detailed examples of how this works but I managed to find this specification that details what I'm talking about:

Below is an example of the coded $DWMY445 that uses a 4-
4-5 accounting calendar.  The first year starts on
02JAN84 and ends on 30DEC84.  Each week begins on Monday.
The accounting year that has 53 weeks is 1989.  The 11th
month has the extra week in the 53 week year.  The two
years in the sample that begin in the same year as the
accounting year have the starting dates of 02JAN84 and
01JAN90

from: 4.7.2.3 Calendar Modifications for 445/454/544 Calendars

With the merging of #22 , I introduced a bug in the calculation of the fields weekOfQuarter and quarterOfYear on RetailCalendarWeek

For the following setup:

    const calendar = new RetailCalendarFactory({
        weekCalculation: WeekCalculation.LastDayNearestEOM,
        weekGrouping: WeekGrouping.Group445,
        lastDayOfWeek: LastDayOfWeek.Friday,
        lastMonthOfYear: LastMonthOfYear.January,
        leapYearStrategy: LeapYearStrategy.AddToPenultimateMonth
      }, 2022)

    const week = calendar.weeks[39]

I expect week.weekOfQuarter to be 0, however I receive 11
I expect week.quarterOfYear to be 4 and I received something else

Use of Moment is discouraged by the project itself https://momentjs.com/docs/#/-project-status/
switching to something like https://date-fns.org/ would reduce package sizes for those using this project.

Some calendars I have encountered seem to allow a leap week to be added to an arbitrary month of the year.

For example, the calendar I am currently working with adds a week to the second month of its retail calendar