holepunchto / libudx Goto Github PK

hey! writing this issue just to keep track.

In order to have portable js we would need to find isomorphic (is that the official naming?) solutions or having our own.

eg. in react-native we don't have:

• util https://github.com/hyperswarm/libudx/blob/093f0a88ba714c907214b343cfb6f3822cd1140e/lib/udx.js#L1
• events https://github.com/hyperswarm/libudx/blob/7b190cb6d6c0470dfa82c29b66fd7c14dbd39092/lib/socket.js#L1
• Error.captureStackTrace https://github.com/hyperswarm/libudx/blob/093f0a88ba714c907214b343cfb6f3822cd1140e/lib/udx.js#L84
• Buffer.allocUnsafe https://github.com/hyperswarm/libudx/blob/6d541cdc75baa0dcd3477255019633a393417eee/lib/stream.js#L294

some shims / polyfills do exist, but you know...

Implement io.h for Windows.

We should be able to piggy bag on RACK heuristics implemented in #118 to add padding to appropriate packages, incrementally discovering the optimal MTU for a connection. @mafintosh likely has more details.

ie, check if stream/socket is closing/destroyed etc in the apis and return an error

https://github.com/mafintosh/libudx/blob/615860d0c0cf1f6102d07b36364ac1f91434d9b7/src/udx.c#L91-L100

i managed to tu hyperswarm 3 replacing utp-native with https://github.com/staltz/utp-native-nodejs-mobile
what could be the workaround for the hyperswarm version 4?

https://github.com/mafintosh/libudx/blob/615860d0c0cf1f6102d07b36364ac1f91434d9b7/src/udx.c#L229-L232

https://github.com/hyperswarm/libudx/blob/7905719da22e8ec5098c671d00adfbc5730a48ce/test/stream.js#L173

Feels like this layer is leaking memory sometimes, we should investigate

See https://www.man7.org/linux/man-pages/man2/sendmmsg.2.html and https://www.man7.org/linux/man-pages/man2/recvmmsg.2.html.

Seems like we might have a bug during start if a lot of packets are sent, one might get dropped and somehow not recovered

https://github.com/mafintosh/libudx/blob/615860d0c0cf1f6102d07b36364ac1f91434d9b7/src/udx.c#L238-L240

https://github.com/mafintosh/libudx/blob/615860d0c0cf1f6102d07b36364ac1f91434d9b7/src/udx.c#L937-L939

I am currently investigating an issue with Hyperswarm, where it is unable to establish a connection between two Docker containers running on different machines on different networks and connected to their respective "bridge" interface (note: when one of the two machines uses "--network host" the connection is established, but this workaround is undesirable for several reasons).

The issue seems to be caused by libudx defaulting to binding to an IPv6 socket, which works within the containers but causes incoming packets to be dropped.

This may be due to IPv6 being disabled by default on the Docker daemon.

By forcing the use of IPv4 in the code below, the issue can be resolved.
If IPv6 needs to be the default, i think a flag should be added to the library, allowing the software using it to force IPv4 when running on platforms with this issue.