The yagi from hneemann

yagi's People

Contributors

Stargazers

Watchers

yagi's Issues

yagi and interface methods

I am using yagi to generate typed collections and have found that it wreaks havoc with interface methods.

.../generics/SyncSlice.go (abbreviated)

package SyncSlice
import "sync"
//generic
type Item interface{}
type Slice []Item
type Collection struct {
        sync.RWMutex
        items Slice
        ts    bool
}
type Collectioner interface {
     Index(int) *Item
}

./flowOuts.go (abbreviated)

// +build go1.10

package flowsBIO

//go:generate yagi -gen=ChIOpacketW -tem=.../generics/SyncSlice/SyncSlice.go -out=flowOuts_yagi.go

// use type aliasing to bridge the naming
type FlowsW = SliceChIOpacketW
type FlowOuts = CollectionChIOpacketW
type FlowOutser = CollectionerChIOpacketW

Results in: ./flowOuts_yagi.go

// generated by yagi ......
package flowsBIO
import "sync"
type SliceChIOpacketW []ChIOpacketW
type CollectionChIOpacketW struct {
        sync.RWMutex
        items SliceChIOpacketW
        ts    bool
}
type CollectionerChIOpacketW interface {
     IndexChIOpacketW(int) *ChIOpacketW
}

Should the interface method signature be left alone, resulting in this instead?

type CollectionerChIOpacketW interface {
     Index(int) *ChIOpacketW
}

For what its worth, I'm generating generics for: ChIOpacketR, ChIOpacketRW, ChIOpacketB and for testing I mock up the resulting Collection* types. I'd rather have a unified 'Index(int) *generic' method, instead of a per generic method signature.

Recommend Projects