hmedina / kasaan Goto Github PK

I've noticed setup.py requires exactly Python version 3.7 (not higher or lower). Is that correct? It seems like too stringent a requirement. Many conda builds of Python framework for Mac OS X still ship Python 3.5. Is this more flexible than setup.py suggests? Thank you!

update:
I get this error:

  File "core/KappaSnapshot.py", line 20
    self._file_name: str
                   ^
SyntaxError: invalid syntax

with Python 3.5. I'm not familiar with the new typing features (which make Python look like OCaml). But is there really a typing syntax that is backwards incompatible between Py 3.5 and Py 3.7? It seems that there is (based on this: https://stackoverflow.com/questions/51789120/type-hints-syntax-error-on-python-3-5). If so, Python is officially the worst language on the planet since Python 3 was introduced...

In any case, all this typing stuff seems really excessive for KappaSnapshot.py. All the core part of the package is doing is parsingstrings with very simple regular expressions. I really doubt that typing buys anything in terms of speed but it makes the code way more complicated. Upgrading to 3.7 turns out to be a major pain because the default Python framework builds for Mac OS X (which are necessary to make matplotlib work - another way in which Python is broken) seem to be Python 3.5.

update 2: I managed to upgrade to Python 3.7 without breaking most of my packages and now it works. I hereby rename this issue "How I Learned to Stop Worrying and Love Python 3 Even Though It's Broken"

In KappaComplex._edge_match(), parallel edges pose a problem with the function used: nx.edges(net, node) returns a list of (a,b) node identifier pairs, and so parallel bonds appear as duplicates in this list. The problem is when querying for bond data with net.get_edge_data(a,b), as this will return only the first of the parallel bonds.

I think tokens should be ignored (they are not complexes).

KaSaAn.core not found when package installed via ./setup.py install --user, but found when ./setup.py develop --user