hkjeldsberg / latexslides Goto Github PK

What steps will reproduce the problem?
1. If I run:
jose@mafalda:~/latexslides-0.31/bin$ ./pdf2odp eca.pdf eca.odp

I get:
./pdf2odp only accepts pdf files, exiting.


What version of the product are you using? On what operating system?

0.31 over Ubuntu 9.04 AMD64, Python 2.6

Please provide any additional information below.

I solve this changing  the line 26 for the following:

**********************
if ext != '.pdf':
**********************

I just added a dot :)

Hi.

Poppler's (http://poppler.freedesktop.org/) pdftocairo utility produces much 
better png images than ghostscript and makes job faster. Also the best result 
achieved when i put a higher resolution (i tried 1600 instead 300). Here is a 
simple patch:

--- ./bin/pdf2odp   2012-12-09 13:55:26.789049070 +0400
+++ ./bin/pdf2odp.new   2012-12-09 15:25:28.543189800 +0400
@@ -27,21 +27,36 @@
     print "%s only accepts pdf files, exiting." %sys.argv[0]
     sys.exit(4)

-# Check for gs
+# converter engine: gs or pdftocairo
+engine = 'pdftocairo'
+resolution = 1600
+
+# Check for converter engine
 try:
-    subprocess.call(['gs', '-v'], stdout=subprocess.PIPE)
+    if engine == 'pdftocairo':
+        subprocess.call(['pdftocairo', '-v'], stdout=subprocess.PIPE)
+    else:
+        subprocess.call(['gs', '-v'], stdout=subprocess.PIPE)
 except OSError:
-    print "You need Ghostscript, exiting."
+    if engine == 'pdftocairo':
+        print "You need Poppler utils, exiting."
+    else:
+        print "You need Ghostscript, exiting."
     sys.exit(5)

-gs_args = ['gs', '-dNOPAUSE', '-dSAFER', '-dBATCH', '-sDEVICE=pngalpha',
-           '-r300', '-sOutputFile=tmp_%s_%%03d.png' %(file), filename]
+if engine == 'pdftocairo':
+    engine_args = ['pdftocairo', '-png', '-scale-to', '%s' %(resolution),
+                   filename, 'tmp_%s_' %(file)]
+else:
+    engine_args = ['gs', '-dNOPAUSE', '-dSAFER', '-dBATCH',
+                   '-sDEVICE=pngalpha', '-r%s' %(resolution),
+                   '-sOutputFile=tmp_%s_%%03d.png' %(file), filename]

-# Try to run gs
-print 'Converting %s to images using gs\n' %filename
-result = subprocess.Popen(gs_args)
+# Try to run converter engine
+print 'Converting %s to images using %s\n' %(filename, engine)
+result = subprocess.Popen(engine_args)
 if result.wait():
-    print '\nRunning gs failed with the error above, exiting.'
+    print '\nRunning %s failed with the error above, exiting.' %engine
     sys.exit(6)

 print "\nDone..."


The patch offers choice between ghostscript and poppler engines using variable 
engine, another choice - png resolution adjusted in variable resolution. 
Probably it makes sense to implement optional arguments for them in the script 
(but i do not program python scripts well)


What version of the product are you using? On what operating system?

latexslides: latest svn snapshot, Fedora 17


Cheers, Alexey.