himasrafeek / buttercake-legacy Goto Github PK

Hi, I have been playing around with Butter Cake for the past few days and I like it. I do not know SASS, as I mostly work in LESS, so please answer my following ignorant questions regarding the distribution compiled CSS:

• Why did you decide to use px for text-size instead of relatives such as em/rem?
• As they are, font-size does not automatically scale with media queries, will this be addressed?

I could not get the navbar menu to open on mobile, the documentation does not say it but it is necessary for jquery and butterCake.min.js to be loaded in the footer and not in the header. You should make that clear

Hi,
In the compiled CSS the .container class does not use the 1260px breakpoint

.container {
    margin: 0 auto;
    padding-left: 10px;
    padding-right: 10px;
    width: 100%;
    /* Breakpoints | Min Width */
}

@media (min-width: 590px) {
    .container {
        max-width: calc(100% - 50px);
    }
}

@media (min-width: 790px) {
    .container {
        max-width: calc(100% - 100px);
    }
}

@media (min-width: 1160px) {
    .container {
        max-width: 1150px;
    }
}

This is because the _containers.scss file does not define container widths for $xl-media. I recommend adding a definition for $xl-media

P.S. you shouldn't close issues until they're resolved. For example, the issue about jQuery should stay open until the jQuery dependency is deprecated. That is to provide a todo-list to you and your contributors and to prevent other people from accidentally opening an issue about the same thing.

Because butterCake identifies as a lightweight framework, it makes sense to ship vanilla JS scripts without jQuery dependency

Removing jQuery would also make Butter Cake easier to use with front-end frameworks such as react

Hi,

Is there a way to have no offset on mobile and also have an offset on desktop?

<!-- 
With this code the offset-2 is always applied 
I want the offset to only be applied when col-md-8 applies
-->
<div class="col-12 col-md-8 offset-2">

I haven't seen attribute for in label tag. I thought that this attribute can associate this label with input, for example.

label tag MDN