hiconfit / hiconfit-core Goto Github PK

// filter out wrong feature models, for example,
// inconsistent
// don't have any constraints
// don't have any mandatory relationships
// don't have any optional relationships
// don't have any alternative relationships
// don't have any or relationships
// the ratio between cross-tree constraints and all constraints is less than 0.1
if (filter
        && (!featureModel.isConsistency()
        || featureModel.getNumOfConstraints() == 0
        || featureModel.getNumOfRelationships(RelationshipType.MANDATORY) == 0
        || featureModel.getNumOfRelationships(RelationshipType.OPTIONAL) == 0
        || featureModel.getNumOfRelationships(RelationshipType.ALTERNATIVE) == 0
        || featureModel.getNumOfRelationships(RelationshipType.OR) == 0
        || ctc < 0.1))
    continue;

Test SolveError

Uses generics for feature model

The FeatureModel class will become FeatureModel<F, R>, where F stands for Feature and R stands for Relationship.

The Feature class maybe become IFeature.

Clean up code

Remove deprecated functions
Use annotations from Lombok
Clean up the code
Add documentation
Add logs

Classes:

Constraint
IOUtils - move getThreadString to ThreadUtils
ChocoSolverUtils
KB
Domain
CmdLineOptionsBase
Domain
Variable
IntVariable
BoolVariable
TestCase

Add CameraKB

Use BufferedWriter.newLine instead of "\n"

Support arbitrary cross-tree constraints in FeatureIDEParser

@taburg recreate new package at.tugraz.ist.ase.fm.cove-v2 and (maybe) at.tugraz.ist.ase.fm.parser-v2, in which contain a new structure (tree) for feature model.

Maybe take a look at IFeatureModel of FeatureIDE https://github.com/FeatureIDE/FeatureIDE/blob/develop/plugins/de.ovgu.featureide.fm.core/src/de/ovgu/featureide/fm/core/io/xml/XmlFeatureModelFormat.java
Need to change the core of fm-package to support complex constraints

An example:

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<featureModel>
	<properties>
		<graphics key="autolayoutconstraints" value="false"/>
		<graphics key="legendautolayout" value="true"/>
		<graphics key="showshortnames" value="false"/>
		<graphics key="layout" value="horizontal"/>
		<graphics key="showcollapsedconstraints" value="true"/>
		<graphics key="legendhidden" value="false"/>
		<graphics key="layoutalgorithm" value="1"/>
	</properties>
	<struct>
		<and abstract="true" mandatory="true" name="test1">
			<and mandatory="true" name="A">
				<feature mandatory="true" name="AA"/>
				<feature name="AB"/>
				<feature name="AC"/>
				<or mandatory="true" name="AD">
					<feature name="ADA"/>
					<feature name="ADB"/>
				</or>
			</and>
			<and name="B">
				<feature mandatory="true" name="BA"/>
				<feature name="BB"/>
				<feature name="BC"/>
			</and>
			<or name="C">
				<feature name="CA"/>
				<feature name="CB"/>
				<feature name="CC"/>
			</or>
			<alt mandatory="true" name="D">
				<or name="DA">
					<feature name="DAA"/>
					<feature name="DAB"/>
				</or>
				<feature name="DB"/>
			</alt>
		</and>
	</struct>
	<constraints>
		<rule>
			<imp>
				<var>AB</var>
				<not>
					<var>CB</var>
				</not>
			</imp>
		</rule>
		<rule>
			<imp>
				<var>AC</var>
				<not>
					<var>CC</var>
				</not>
			</imp>
		</rule>
		<rule>
			<not>
				<conj>
					<var>ADA</var>
					<var>AB</var>
				</conj>
			</not>
		</rule>
		<rule>
			<disj>
				<var>ADB</var>
				<not>
					<var>BC</var>
				</not>
			</disj>
		</rule>
		<rule>
			<disj>
				<var>BC</var>
				<imp>
					<var>CA</var>
					<var>CB</var>
				</imp>
			</disj>
		</rule>
		<rule>
			<imp>
				<var>DAA</var>
				<not>
					<conj>
						<var>AB</var>
						<var>AC</var>
					</conj>
				</not>
			</imp>
		</rule>
		<rule>
			<imp>
				<var>AB</var>
				<disj>
					<var>AC</var>
					<not>
						<var>DAB</var>
					</not>
				</disj>
			</imp>
		</rule>
		<rule>
			<imp>
				<var>DB</var>
				<not>
					<not>
						<var>AB</var>
					</not>
				</not>
			</imp>
		</rule>
		<rule>
			<imp>
				<var>DB</var>
				<not>
					<not>
						<not>
							<not>
								<var>AC</var>
							</not>
						</not>
					</not>
				</not>
			</imp>
		</rule>
		<rule>
			<imp>
				<var>DAA</var>
				<disj>
					<var>AB</var>
					<not>
						<var>AC</var>
					</not>
				</disj>
			</imp>
		</rule>
	</constraints>
</featureModel>

hiconfit / hiconfit-core Goto Github PK

hiconfit-core's People

Contributors

Watchers

hiconfit-core's Issues

Recommend Projects

Recommend Topics

Recommend Org