Code Monkey home page Code Monkey logo

grav-theme-learn2-git-sync's Issues

Blank space in all my code blocks

If I create a multiple line code blocks I see a blank space on the first line. I can't figure out why and it's driving me crazy :) Any thoughts?

For example all my code looks like this:

 blaa -blaa -blaa
Testing 123 test test

NOTE: I'm intentionally putting a space in here to describe what I'm seeing.

Missing logout link

This may be more of a feature request than an issue.

When you login to the site as a normal user (NOT the admin panel), there is no way to logout again. The quark theme has a logout link, but Learn2/Learn2-git-sync do not.

See this for more info.

While I have already added a custom theme which inherits this theme with the suggested changes, it might be handy to have it show up by default (or perhaps an option).

This is what I added to put the logout link in the sidebar, just above the "Built with" text:

templates/partials/sidebar.html.twig (added between the footer and feed link):

{# Added by Tim M. - adds a logout link to the sidebar #}
            {% if config.plugins.login.enabled and grav.user.username %} <span class="login-status-wrapper"><i class="fa fa-user"></i> {% include 'partials/login-status.html.twig' %}</span><br><br> {% endif %}
{# Ends the logout link code #}

The bottom part of the file looks like this:

        <a class="padding" href="#" data-clear-history-toggle><i
                    class="fa fa-fw fa-history"></i> {{ 'THEME_LEARN2_CLEAR_HISTORY'|t }}</a><br/>
        <section id="footer">
{# Added by Timinator - adds a logout link to the sidebar #}
            {% if config.plugins.login.enabled and grav.user.username %} <span class="login-status-wrapper"><i class="fa fa-user"></i> {% include 'partials/login-status.html.twig' %}</span><br><br> {% endif %}
{# Ends the logout link code #}
            {% if config.plugins.feed.enabled and pages.find('/feed') %}
              <a class="button" href="{{ base_url }}/feed.atom"><i class="fa fa-rss-square"></i> Atom 1.0</a>
              <a class="button" href="{{ base_url }}/feed.rss"><i class="fa fa-rss-square"></i> RSS</a><br><br>
            {% endif %}
            <p>{{ 'THEME_LEARN2_BUILT_WITH_GRAV'|t|raw }}</p>
        </section>
    </div>
</div>

Multisite compatibility

Hi,

This is a followup of #13. I think I delved too far in the rabbit hole. :)
There are other instances of code that prevent full compatibility with multisites.

For example in templates/partials/github_link.html.twig:

{% set git_repo_edit_link_url = git_repo_link_url ~  ('/'~page.filePathClean)|replace({'/user/':'/'}) %}

would output:
https://github.com/REPO/blob/master/sites/SUBSITE/pages/01.install/docs.md
while the correct link would have been:
https://github.com/REPO/blob/master/pages/01.install/docs.md

I am not fluent enough in Twig, so I hacked the code like this for my own convenience:

{% set git_repo_edit_link_url = git_sync_repo_link ~ 'blob/master' ~ ('/pages'~('/'~page.filePathClean)|split('/pages').1) %}

I guess there are smarter ways to do so, maybe by relying on local_repository key in the config or retrieving the actual user:// path for the subsite and removing it from page.filePathClean?

Built with Grav link is not displayed correctly

The text displayed on the bottom of the sidebar is as follows:
Built with <a href="http://getgrav.org">Grav</a> - The Modern Flat File CMS

There is no clickable link, it is displaying the text literally.

If I edit templates/partials/sidebar.html.twig and add |raw to the variable expansion, it works:
<p>{{ 'THEME_LEARN2_BUILT_WITH_GRAV'|t|raw }}</p>

That displays a clickable link:
Built with Grav - The Modern Flat File CMS

I suspect that's a bug, but it's also very possible I have something else configured wrong, thus requiring the use of raw?

Thanks for checking.

Slash is not added at the end of a custom git repository url for the "Edit this page" link

Steps to reproduce:

Set the git remote url to "others" with the repo url without a slash at the end.
e.g. http://tfs-host.com/tfs/MyCollection/MyProject/_git/wiki

Open a page and click on the "Edit this Page" link.

Expected result:
Link should be http://tfs-host.com/tfs/MyCollection/MyProject/_git/wiki/blob/master/pages

Actual Result:
Link is http://tfs-host.com/tfs/MyCollection/MyProject/_git/wikiblob/master/pages

Workaround:
Add a slash in the repo url
http://tfs-host.com/tfs/MyCollection/MyProject/_git/wiki/

BTW, it is not happening with github.

Enhancement Question

This theme is near perfect for what I want to use it for - open textbook. Have been looking at Jupiter books, and I love following features:

  • the ability to collapse the sidebar
  • have subsections of a single page (probably headers) as a right sidebar
  • PDF and epub export

Has this been discussed for Learn2 yet?

New to grav themes but would love to help out!

Bug in Advanced Fulltext Search: Wrong URL

The advanced fulltext search directs to /tntsearch resulting in a 404 Not Found. It should be /search instead. The advanced search is achieved by calling /search/query:some keyword.

Dynamic Page Visibility

I'm with a fresh install of Grav using Learn2-Git-Sync, and I'm having trouble creating a folder with private information on in. I was able to make the parent page hold the rules and all the pages on the folder follow the same rules (parent_acl), but I can't find a way to make those pages hidden when the user is not logged in. I've set dynamic_page_visibility to true or enabled everywhere I could find it, with no success :/

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.