git status isn't clean after a build about hhvm-third-party HOT 6 CLOSED

@gdbentley I am assuming you are getting a dirty hhvm-third-party after building hhvm, right?

Have you done the following:

% rm -rf third-party
% git submodule init
% git submodule update --init --recursive

and see if you get the dirty repo?

cc: @drilibo

from hhvm-third-party.

I'm going to have to tell you the same thing... not sure what we can do about this since we just submodule that in. mysql-5.6 needs to have a fix, and if they don't want to take one directly, then one needs to go upstream and then into that repo.

@JoelMarcey this has nothing to do with the switchover itself.

from hhvm-third-party.

Oh ok... thanks @jwatzman

from hhvm-third-party.

BTW @JoelMarcey apologies if what I wrote above comes across as snippy/rude, wasn't my intent, but reading this thread again I realize it could have come off that way!

from hhvm-third-party.

To be clear, I just wanted to document for others why this used to work and doesn't anymore. I like to do a git status before wiping out an hhvm development tree, and it surprised me when I started getting a dirty status.

from hhvm-third-party.

@jwatzman I didn't take it that way :)

from hhvm-third-party.