thrift includes not found about hhvm-third-party HOT 8 CLOSED

did you do git submodule update --recursive --init? It is now a submodule.

from hhvm-third-party.

Sure. Everything else (like folly) works, too.

from hhvm-third-party.

Oh, i thought your src was empty. Can you please paste your error messages.

/cc @djwatson

from hhvm-third-party.

features.h only linux and gcc

• #26
• https://gcc.gnu.org/onlinedocs/gcc-4.6.2/libstdc++/api/a00869.html
• http://www.cs.fsu.edu/~baker/devices/lxr/http/source/linux/include/linux/in6.h

#if __ISO_C_VISIBLE >= 2011 || __cplusplus >= 201103L
# if defined(__linux__)
#  include <features.h>
# endif
#endif

[ 19%] Building CXX object third-party/thrift/thrift/lib/cpp/async/TAsyncServerSocket.cpp
In file included from thrift/lib/cpp/async/TAsyncServerSocket.h:28:0,
                 from thrift/lib/cpp/async/TAsyncServerSocket.cpp:21:
/usr/local/Cellar/hhvm/HEAD/src/third-party/thrift/thrift/lib/cpp/transport/TSocketAddress.h:25:22:
fatal error: features.h: No such file or directory
 #include <features.h>
                      ^
compilation terminated.

from hhvm-third-party.

[ 18%] Building CXX object third-party/thrift/CMakeFiles/hphp_thrift.dir/thrift/lib/cpp/async/TAsyncServerSocket.cpp.o
/Library/Dev/hhvm/hphp/util/alloc.cpp: In function 'void HPHP::init_stack_limits(pthread_attr_t_)':
/Library/Dev/hhvm/hphp/util/alloc.cpp:89:35: error: 'AsyncFuncImpl' has not been declared
const size_t stackSizeMinimum = AsyncFuncImpl::kStackSizeMinimum;
^
make[2]: *_* [hphp/util/CMakeFiles/hphp_util.dir/alloc.cpp.o] Error 1
make[1]: *** [hphp/util/CMakeFiles/hphp_util.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 18%] Building CXX object third-party/folly/CMakeFiles/folly.dir/folly/IPAddressV6.cpp.o
In file included from /Library/Dev/hhvm/third-party/thrift/thrift/lib/cpp/async/TAsyncServerSocket.h:28:0,
from /Library/Dev/hhvm/third-party/thrift/thrift/lib/cpp/async/TAsyncServerSocket.cpp:21:
/Library/Dev/hhvm/third-party/thrift/thrift/lib/cpp/transport/TSocketAddress.h:25:22: fatal error: features.h: No such file or directory
#include <features.h>
^
compilation terminated.
make[2]: *** [third-party/thrift/CMakeFiles/hphp_thrift.dir/thrift/lib/cpp/async/TAsyncServerSocket.cpp.o] Error 1
make[1]: *** [third-party/thrift/CMakeFiles/hphp_thrift.dir/all] Error 2

from hhvm-third-party.

since thrift is a submodule now, doesn't that mean that this issue should be filed over there and closed here? or am i misunderstanding the issue?

from hhvm-third-party.

Yeah, this looks like an issue with upstream thrift. @denji points out that features.h is apparently Linux-only? #26 fixed that for us a while, it's possible that upstream thrift regressed. @xssworm if you're still running into this issue, please reopen it against upstream thrift -- pointing them here wrt features.h explanation might be useful context, but they need to fix this, and then we can update to the fixed rev.

from hhvm-third-party.

@jwatzman facebook/hhvm#4444

from hhvm-third-party.