hewlettpackard / lustre-csi-driver Goto Github PK

In the files deploy/kubernetes/lustre-csi-driver.yaml and deploy/kubernetes/lustre-csi-driver-kind.yaml, imagePullPolicy is being set to "Always". I do not think that this is a good default.

I would suggest that is is best to not set this at all, and accept the default policies from the kubernetes environment. We, for instance, are going to want to us "IfNotPresent" rather than "Always".

I would suggest that we omit the imagePullPolicy field from your manifests. Kubenetes' default behavior for selecting a policy when one is not specified seems pretty sane to me:

https://kubernetes.io/docs/concepts/containers/images/#imagepullpolicy-defaulting

and when we use labels that are note "latest", we at least would get the behaviour of "IfNotPresent". If you want to use "latest" and live on the bleeding edge, you can have "Always" selected for you automatically.

There are a couple bugs in the Usage example:

1. The claimRef in the PV references a PVC in the lustre-csi-system namespace, but it should be default. Without this change, the example does not work.
2. The PV and PVC have an access mode of ReadWriteOnce, but should be ReadWriteMany as Lustre supports this mode and is the common way to use Lustre

The readme references what is in this repo as v0.0.1 but there are no branches/tags with that designation and no container in ghcr.io with that designation.

I suggest doing a release (see here), which might also require updating the GitHub action to build and push the release.