heuristnetwork / heurist Goto Github PK

Register allows you to request access to the database (it is enabled by a checkbox in database properties) AND creates a profile, but this needs to be distinguished from someone who already has a Heurist profile (who currently needs to "Contact the owner").

• Add a blank line where shown by > and <
• Should not show N/A (not sure what this is meant to render)
• Change text as follows:
  All Heurist databases require a login. If you wish to access the data this database but do not have a login for it, please click the Register button (if shown), otherwise email contact the owner:

<db owner - user #2>, N/A 


Currently, once you go into source code (text) editing mode, you onlyu have the ioptions of going to the wysiwyg editor or saving the changes. Should jsut be able to cancel and drop any changes.

We need some way such as arrows like this to reset the min and max to the min and max values, because if you've zoomed in it can take 10 clicks to zoom out to where you need (other than resetting completely):

There is already “reset” button, that set min/max values for slider. I know, that is not the same. I may have set the maximum to what I want, but the minimum is wrong, or vice versa

It would be useful to know that you are logged into Heurist when accessing a Heurist website (this doesn't need to be a dropdownmenu, simply the image and name of the person).

Branch name: archefact-storedfunctions

Purpose of code changes on this branch:

 - Created stored functions to replace levenshtein.c and liposuction.c UDFs

When reviewing my code changes, please focus on:
 - Validating that the functions indeed perform identically. This can be done by loading them onto a server that has the UDFs under a different name, and running SELECT oldfunction(...),newfunction(...) type queries.

After the review
 1) UDFs unloaded/removed from server(s)
 2) new functions loaded into every existing database
 3) new functions appended to the sqlProceduresTriggers.sql file
 4) mark branch as merged/finished.

Original issue reported on code.google.com by [email protected] on 11 May 2013 at 8:10

Put a message (leave a bit of whitespace above and left, 12 point font):
Preparation of zip archive may take several minutes for large databases.
Please do not close the popup.

to reflect change in inrterface

Structure > Visualise : Change style of connection lines to render the dotted lines in a very faint grey - just enough to be visible so that the ones that have been used really stand out.

Overlap of checkbox and icon in dropdown for choosing entity buttons

add "all:" to the search-everything search
.it is not finding text in text field "Short description" ("trolls" exists in the data). Search all means search all … This is intended for public use, how is some member of the public expected to know it isn't searching all or how to add obscure Heurist search methods?

check that ALL reads of external data - in delimited import, synchronisation, KML, bookmarklet, html import - are trimmed.

The reopen righthand panel button 1. doesn't look like anything 2. is stuck up in the top right in the margin where no-one could recognise that it has anything to do with a panel which they probably don't even realise is missing. I think the panel should remain as a narrow strip with a clear Maximise or expand-left icon in it

Hagen Peukert: At HEURIST/HEURIST_SUPPORT/external_h5/jquery-file-upload/server/php/UploadHandler.php line 453 the FILESTORE path is hardcoded as
$upload_path = $this->get_upload_path($file->name, $file->subfolder);
if(!(strpos($upload_path,'/var/www/html/HEURIST/HEURIST_FILESTORE')===0 || strpos($upload_path,'C:/xampp/htdocs/HEURIST_FILESTORE')===0)){
$file->error = $this->get_error_message('only_heurist');
return false;
}
Instead of '/var/www/html/HEURIST/HEURIST_FILESTORE' it would be great to put the variable $defaultRootFileUploadPath from the configuration file there. I have checked the visibility of this variable and it is not accessible in this directory/file. Yet, it is really something important if the installation directory is to be kept variable/flexible.

Branch name: archefact-remotes

Purpose of code changes on this branch:

added -h param to mysql and mysqldump calls to enable using remote MySQL server
added config options for memcached
graceful degradation for memcached (on fail or if not there)
few comment typos


After the review, I'll merge this branch into:
/h3share

Original issue reported on code.google.com by [email protected] on 11 May 2013 at 8:01

For edges (links) defined by a relationship, add output of the fields in the relationship record as attributes of the edge In gephi export? Fields in relationship: interpretation, validity, description, notes? and any other fields which the person has added to the relationship type

Yes, we should ... Currently all issues are in a Heurist database and a Google Doc for immediate/current work. Longer-term design and new features backlog, and individual project specifications, are also in the Heurist database and Gdocs.

If you pass an &q= parameter in the URL to the Heurist main page, but the person is not logged in to the database, the login popup will appear, but after login it will display the main page with the default query set in the user's profile (by default sortby:-m = most recent records at top) ie. it loses/fails to apply the passed query parameter

End-user documentation is maintained in a HelpnDoc .hnd helpfile and published at https://heuristplus.sydney.edu.au/help/index.html.

The helpfile is somewhat out-of-date (only minor updates since late 2017, it has not been updated to reflect interface revisions and new features between Vsn 4 and Vsn 5).

More recent help is available through items on the HeuristNetwork.org website.

Add following country domains to admin/setup/dboperations/welcomeEmail.php


be, ch
line 61: if(strtolower(substr($user_record['ugr_eMail'], -3)) === '.fr'){

The blue of icons should be the same as the blue of the record type browse rows
The big + icon is too close to the left edge
The network (visualise) icon should be part of the hotspot

Currently you see a "synch listed entity types" button on the screen, but do not see the Import Records button (it's off the bottom). The synch button may not be needed, better to put up top as shown. Make sure line spacing is right once you've moved it, try and avoid Import Records going off the page unless there is a very long list of entity types to match.

Branch name: archefact-fixes

Purpose of code changes on this branch:

 - Change absolute to relative path so hostname will be used in url. This fixes editing geolocations in editRecord. 
 - Change any SQL facing addslashes() with MySQL and character set aware mysql_real_escape_string()

After the review, I'll merge this branch into:
/h3share

Original issue reported on code.google.com by [email protected] on 11 May 2013 at 8:03

• When you open up the digitiser (record editor) and search for a place, it shows a place mark, but if you then hit save it says you have to digitise a location. If you add a placemark you then have two - only the one you added is saved. Placemark shown should be set as the location digitised.
• If you add several spatial objects in the digitiser, only the last one drawn is saved in the record.
• The use of this is initially rather obscure. Put an "🛈 How to use this" link in the righthand panel, maybe at the top, laid out well, with 🛈 in blue circle

We need a way to add records allowing the URL to tell the user how to login as a guest (or other user) - needed by Hamburg for requesting database corrections, will also be useful for Beyond 1939 project and probably TLCMap, for example:
..../recordEdit.php?db=johns_hamburg&rec_rectype=71&rec_visibility=public&loginas=guest+guest

• Move "Heurist markup language" below heading.
• Move "Follow all pointers" checkbox as shown, align checkobxes
• Close up space created at bottom.

"record type"not "rectype" in ALL end-user messages.
Do a search for " rectype" and "rectype ", you will probably find others

Add to message. "Custom scripts are Javascript stored in the website and/or menu records. Please ask the system administrator to enable custom scripts"

Add a message in place of the last line:

"Please run Verify > Verify database integrity. If this does not find and fix errors, please send a bug report (Help > Bug report) and we will investigate the problem."

If user

• unchecks the follow all pointers checkbox, pop up a warning (because this can really generate stuffed-up data if they don't know what they are doing):

WARNING
You have chosen not to follow pointers.
Record pointer fields in this set of records will NOT be exported.
The data for these records will therefore be incomplete. Use with caution.
[Proceed] [Cancel]

Global search for alerts. There 538, of which a couple of hundred are short messages like "Title is required" or "Record saved". All of these short alerts should be converted to flash messages (easy - I already went through all the alerts checking and standardising the text, and it only took me half an hour or so), with a constant time (shortAlertMsecs, initially 1000, we can play with that as required, easy), and positioned appropriately (which requires testing each alert - not so quick - but we could start with defaulting them to a fixed position such as x=400, y=300). This is probably a couple of hours work, even if some alerts are not ideally placed it is still better than the current set of popup alert boxes.

Move dashboard into a 'ribbon' below heading
Reduce size of icons to 70% of current
Reduce spacing and maximum length of description so it all fits nicely as shown
New close and edit - make sure the close up/open down arrow is sufficiently bold as shown, not some tiny thing. No need for the temporary close button
Reverse arrow direction when closed to allow reopen. Remove the special [Dashboard] control in the page header - I think the up / down arrow is sufficient.
Dashboard open for new databases. Once closed, dashboard should stay closed until reopened by user (ie. state is current "Don't show again")

WAS: The dashboard really gets in the way once you are a user. It's really intended for starters. Change order of controls at top and wording of buttons to make it clearer how to get rid of it:

Link to context_help/zotero.html (new file just committed) something like this (pop up help on top). Note, I have edited 18/5/18 the editSysIdentificationAll file to extend the field length which was set to 63/70 although data was varchar(1000) & removed old versions: editSysIdentification/Advanced

We need to show that there is hidden data not just hidden fields. In this case, render the hidden fields message at the end in red with the addition of "which contain data":

"There are hidden fields in this form which contain data. Modify structure to enable them.

This doesn't tell me what's wrong, only that something is wrong. What menu item can't find its parent?

Current workflow hides our level of activity because we don't use conventional gitHub workflow. Need to move from continuous incremental development to update of Master and marked releases .

This dropdown is FAR too short, making it really difficult to use. Make it as long as possible in either dropdown or drop-up direction

This line and a few onward refer to the Google Analytics ID, hard-coded. This means that installs elsewhere will pollute the analytics.
So this should be in the Heurist config, not the code.

Advanced query: please check each of the buttons to see that they work. There are two or three that do not do anything. Please make those work, just as a quick fix - down the track I w2ant to build a proper advanced search wizard with multiple criteria, and, or etc.

This ugly wrapping (top) occurs almost all the time if there are a few pages, even with short saved search title. Move display mode down to line with menu, shorten the display of multiple pages, so it stays on two lines except in exceptional circumstances.

If user unchecks "follow all pointers" give them the following warning popup:

WARNING: by allowing the export of records without following pointers, you will lose any data which is referenced by pointer fields in the exported records. This may be acceptable for simple lists eg. of places or person names, but you need to understand the nature of the exported records to be sure that you are not losing essential data.
Exporting and importing a CSV file will give you more control on what fields are exported.
Are you sure?
[ Proceed ] [Cancel]

There is a loooong delay (several minutes) with no action when zipping a large database:. We MUST have a progress report. More generally, can we solve the problem of caching of progress report output.

Put a collapsible wrapper around each of the top level entries in the second list, as per below. This shouldn't take you more than a few minutes I believe. You can then hide the top list b/c it will be identical. You don't need to worry about the indents if difficult.
It randomly checks the boxes next to the first few required pointers, but not all. By default NO pointers should be checked


With indents:

When entering the password from Firefox (63.0), the pwd field flickers and generally only stays at the first character, so you can't login. Looks like there is some Javascript actively interfering during the typing.
On Brave and Chrome browsers it's ok.

Can the pop-in data view for the results list set its length to the length of the contents? Currently get huge blank (this is where it matters) or only see half the data (in the end, this isn't really a problem, after all iti s embedding itself in a list or a map, we don't necessarily want it taking up teh whole of the available space).

• White on grey is very hard to read, looks like it might be disabled
• Nothing shows you that the bottom two have submenus. Needs an arrow or filed triangle to the right of the menu entry

After loading 13600 of 13646 when importing XML (also CSV) it sits like this for several minutes. It needs some alternative processing message to show that it has not simply hung.
It would be good to replace this rather strange loading message with a progress bar, or even just a simple non-graphic message "loading xxxxxx of yyyyy records" .

Branch name: archefact-all

Purpose of code changes on this branch:
merge of master (v3.1 public release) and h3share
merged all of archefact-fixes, archefact-storedfunctions, archefact-remotes

When reviewing my code changes, please focus on:
Merge mistakes (always useful to do a quick review on the diff)

After the review, I'll merge this branch into:
master or h3share

Original issue reported on code.google.com by [email protected] on 17 May 2013 at 3:58

Improve layout - currently you see a "synch listed entity types" button on the screen, but do not see the Import Records button (it's off the bottom). The synch button may not be needed, better to put up top as shown. Make sure line spacing is right once you've moved it, try and avoid Import Records going off the page unless there is a very long list of entity types to match.