hesketh / mecatolarchives Goto Github PK

Provide a short guide to how people (me included) should be contibuting to the project.
Workflows, style guide, etc.

With additional factions being able to be added there should be a way of storing the icon for these factions within the database. So that new factions can be added fully fledged and fit alongside the original factions properly.

GitHub Actions presently just build main and push to 'latest' docker version. It instead needs to become:

• Tags are built and published as the tag. e.g. as v1.1, v1.0
• main is built as latest as before
• development is built as a 'development' image
• PRs must be built but not published to ensure that they actually build

Layouts on mobile work, but there are many odities that would be good to clear up.

For example the table used in the data pages looks has a blank gap along the right side roughly the size of the add new button.

Players from the game history should be sorted by

Not Eliminated > Eliminated
Then by Victory Points

Variants/Expansions are not selected in the UI on edit
Meaning they are lost if you save after opening up the edit UI

Define how users should report security vulnerabilities for this repository in a Security policy.

GitHub provides further information about this in the Security tab of the repository.

Assets have been used from other sources. And although they are referenced within the source a document collating everything used should be put together.

The logic has got flipped and now the edit game button is only visible when not signed in.

This is more to make things clear to the users who are here to see the stats. The data section is more of a data input section and although there is no harm in users being able to view these sections it will just lead to confusion

Player's love looking at their statistics and visual formats of this will just improve the experience at a glance.

• Graph of VP% in the past few games?
• Chart of Faction pick distribution
• Chart of Win/Loss/Draws?

Play's will gravitate to a certain colour to represent themselves.

Therefore if we add a default Colour field to a Person we can autoselect their preference in the forms

On the player page you can look at a history of that player's previous games.

The same thing should be added so you can view the faction's previous games.
This will require a new endpoint into the API.

The order games are turned is in reverse (i.e from oldest to newest)

This should be newest to oldest

Add a button on the faction pages to open the wiki page for that faction.

Maybe this should be user enterable and optional in the data page.

The add button on the person page does not function. Making it impossible to add players.

Investigation of the containers logs indicate its a null ref in Get Initials

      System.NullReferenceException: Object reference not set to an instance of an object.
         at Hesketh.MecatolArchives.API.Data.Person.get_Initials() in D:\a\MecatolArchives\MecatolArchives\API.Data\Person.cs:line 15
         at System.Text.Json.Serialization.Converters.ObjectDefaultConverter`1.OnTryWrite(Utf8JsonWriter writer, T value, JsonSerializerOptions options, WriteStack& state)
         at System.Text.Json.Serialization.JsonConverter`1.TryWrite(Utf8JsonWriter writer, T& value, JsonSerializerOptions options, WriteStack& state)
         at System.Text.Json.Serialization.JsonConverter`1.WriteCore(Utf8JsonWriter writer, T& value, JsonSerializerOptions options, WriteStack& state)
         at System.Text.Json.Serialization.Metadata.JsonTypeInfo`1.Serialize(Utf8JsonWriter writer, T& rootValue, Object rootValueBoxed)
         at System.Text.Json.JsonSerializer.WriteString[TValue](TValue& value, JsonTypeInfo`1 jsonTypeInfo)
         at System.Text.Json.JsonSerializer.Serialize[TValue](TValue value, JsonSerializerOptions options)
         at MudBlazor.MudDataGrid`1.SetEditingItemAsync(T item)
         at Hesketh.MecatolArchives.Website.Components.Pages.Data.PeoplePage.CreateNew() in D:\a\MecatolArchives\MecatolArchives\Website\Components\Pages\Data\PeoplePage.razor:line 67
         at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)
         at Microsoft.AspNetCore.Components.Rendering.RendererSynchronizationContext.PostAsync[TState](Task antecedent, Action`1 callback, TState stat

A viewer should be written to translate the Map String that can be stored for each Play into a visual representation.

In the same vein as https://keeganw.github.io/ti4/

Yeah absolutely bonkers mistake. If a user logs in then everyone will be logged in.

A README should be added to the root of the repository that informs people on

• Project Goals
• Project Features
• Screenshots of implementation
• Link to the hosted example on Hesketh.Dev

When deployed using a Docker image and served behind a remote nginx proxy the Fonts are not being served to the client.

downloadable font: download failed (font-family: "AmbroiseFirmin" style:normal weight:700 stretch:100 src index:0): status=2147746065 source: http://192.168.69.2:3003/Fonts/Ambroise%20Firmin%20Bold/Ambroise%20Firmin%20Bold.otf
downloadable font: download failed (font-family: "MyriadPro" style:normal weight:400 stretch:100 src index:0): status=2147746065 source: http://192.168.69.2:3003/Fonts/Myriad%20Pro/Myriad%20Pro%20Regular.ttf

When an administrator is on the Faction Data page the table displays incorrectly due to the faction images.

Stats are to tell people the story of how they are done. And if we add a game in the future as a placeholder then we will skew a players statistics in a way they dont care about.

Therefore games without a winner (i.e. not completed) will not be counted for stats

This will be an option that can be set on a Person that indicates whether they should be included in the visual display of leaderboard.

This way players that have only ever played once and are unlikely to make an appearance can be hidden from the display on the leaderboards page.

Migrations currently only work for an MSSQL DB connection.

They should support

• SQLite
• In Memory
• MSSQL

Documentation and Instruction for how to deploy and host an instance of the servers within the repository.