Code Monkey home page Code Monkey logo

sliceconv's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

sliceconv's Issues

Package should have tagged releases

Adopting semantic versioning using git tags will allow users to differentiate versions of the package and, more importantly, identify when the package has made a breaking change.

Atoi tests are missing error cases

The table driven tests for the Atoi function are missing the error cases; cases where one or more of the provided strings are not integers. These cases should be added for full test coverage.

README should reflect float support

As of now, the README only describes the usage of the package between integers and strings. It should be updated to reflect the newly added support for floats and strings as well.

Missing support for floats

The current package only supports slice conversion between strings and integers. Add support for float64 as well.

Reflect v1.0.1 in README

When issue #18 is resolved, the README needs to be updated to reflect the changes. One of the examples lists the current accepted boolean string representations.

Missing support for bools

The current package only supports slice conversion between strings and integers. Add support for bool as well.

Variadic parameters are unwieldly in this context

Although variadic parameters seemed like a good idea at the time of creating the package, they actually lead to extra boilerplate when calling the package functions. The sliceconv package is meant for converting slices of primitive types to another slice of a primitive type; the use-case of converting a single variable is already covered under the regular strconv package and is out of scope for this package.

Package functions should simply take a slice of primitive types.

Package is missing a README

There is no README for this package yet. Add a README file with information on what the package is used for, how to use it and how to contribute. Also add build status, test coverage, and Go report card score.

Change Atob to be case-insensitive

As of v1.0.0, only "true", "True", and "TRUE" are valid string representations of boolean value true. This is the same for the false boolean value. There is no reason to not accept any combination of upper and lowercase characters.

README should reflect bool support

As of now, the README only describes the usage of the package between integers, floats, and strings. It should be updated to reflect the newly added support for bools and strings as well.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.