henry-sarabia / apicalypse Goto Github PK

Found this while opening a PR against the igdb library. The build for the PR listed the following error when trying to grab the dependencies:

# github.com/Henry-Sarabia/apicalypse
../apicalypse/option.go:53:7: undefined: blank.RemoveSpace
../apicalypse/option.go:74:7: undefined: blank.RemoveSpace

Digging into it, the blank library updated to rename RemoveSpace to just Remove a few months ago.

When multiple "Where" filters are applied to a single query, each filter is consecutively overwritten by the next in line. This is a side effect of using a map[string]string which maps a filter name as a key to its contents.
To fix this, amend the code to check for an existing value in the filter map under the "where" key. If one is found, simply AND the filter's together with concatenation. If not, continue normally.

The current README needs the following 3 changes:

• The package name apicalypse should be bolded just like that
• The godoc reference link should now point to the new go.dev
• There should be a small reference to IGDB in case users find their way here instead of to the IGDB package.

With the renaming of FuncOption to Option, the previous Godoc link is no longer valid. This should be replaced with a new link pointing to the Option section of the documentation.

Package whitespace has been updated to v2.0.0 with breaking changes including a name change. Change all occurrences of this package with new naming scheme.

The current README does not have any documentation for the latest addition to the package - the Query function.

The file names do not reflect the renaming of the FuncOption type to Option.
funcOption.go and funcOption_test.go should be renamed to option.go and option_test.go respectively.

Adopting semantic versioning using git tags will allow users to differentiate versions of the package and, more importantly, identify when the package has made a breaking change.

As of v1.0.3, apicalypse will be its own module