henrahmagix / github-oauth-prompt Goto Github PK

If you get a token with public scope for your unique name, then try to get it again with private scope, the previous token will be fetched and no notification that the token does not allow private access. Only upon using the token will you find that you don't have access.

• Compare the requested scopes to those of the fetched existing token and alert the user

An error should not be thrown. Alert "existing token found for but scopes do not match."

Should the fetched token of incorrect scopes be returned, or should the task fail?

Woo! Promises!

• In all cases, if the callback parameter is undefined, use a promise and return it.

Coming from popomore/github-labels#3.

I'm not getting an SMS with the example:

var oauth = require('github-oauth-prompt');

oauth({name: 'test-token'}, function(token) {
  console.log(token);
});

https://github.com/henrahmagix/github-oauth/blob/31fcf2dac1ac058c73aae28c0131ce215719e2e5/test/api-response.js#L214

So it seems that maybe github changed something, the method you're using to get back an existing token won't work because all tokens are empty strings. From a quick search it seems impossible now, maybe you should just throw an error ?

Like this from https://developer.github.com/guides/basics-of-authentication/