Code Monkey home page Code Monkey logo

fetch-twitter-bookmarks's People

Contributors

helmetroo avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

fetch-twitter-bookmarks's Issues

Break up long methods

Create a ScrollState interface to represent scroll progress to help break down extractTweets method.

CommandLineInterface.run() should be broken up.

CLI argument pertaining to cursor

Need to also firmly decide which behavior most makes sense as the default.

Argument should decide if we

  • Fetch from the very beginning
  • Fetch from a specific cursor
  • Fetch from the last cursor (current working default)
  • Allow for tweet ID or timestamp as a starting point (if a means through API can be figured out)

Pull browser methods out of extractor class

Should probably have a separate class that maintains the browser and bookmarks page for the extractor to extract tweets from. Also want to make Puppeteer classes like Browser and Page mockable for testing

Automated tests

Ideas:

  • Download a working copy of the bookmarks page that can work without logging in, replace network requests with test data

Tests:

  • Ensure all tweets are downloaded if maxLimit not set
  • Ensure only maxLimit tweets are fetched if maxLimit set
  • CLI should error if invalid parameters are given
  • ...

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.