helmbold / rxfilewatcher Goto Github PK

A Path for a non-default FileSystem might be used for creation yet the created observables assumes it can watch from FileSystems.getDefault(). The FileSystem from the supplied Path should be used.

Hello :) I guess you have to close WatchService after use

Currently registration of directories happens in the constructor of ObservableFactory. This is incorrect as the observables being created are cold, not hot. Registration should be deferred until subscription happens.

The name of DirectoryObservable in the context of RxJava messages that it is a subclass of rx.Obserable and also that instances of it will be used by consumers (like ConnectedObservable, BlockingObserable, etc.) yet neither is true.

I would suggest changing the name to PathObservables. Path is the subject of the observables being created and the plural of Observable indicates its a utility class with static methods. As to the method names, using something like watch and watchRecursive describe the implementation of the observable which takes the subject (Path) as an argument.

As in usage place we might have no context information about the parent, and relative path not enough.

The problem here that per one instance of this we can track single directory(+recursive). So If the amount of tracking candidates vary during program lifecycle, it appears that per each I need create new Instance that will ate another thread.
But we can utilize existed thread that already created during previous instances.
And no, I am not asking for single thread per all, as this may cause StandardWatchEventKinds.OVERFLOW. Many threads is good. 1 thread per 1 folder - not so good. So having some way to alter existed watchers by adding/removing targets is best option.

Do you have try in Window or Linux OS?

When the consumer of a created observable unsubscribes the loop is not shut down.

After onError is invoked, no events sent to onNext or onComplete will be sent downstream per the contract of Observable (and enforced by RxJava's SafeSubscriber). The loop should break, not continue if such an exception occurs.