hellobetterltd / markdownfield Goto Github PK

Can you add a screenshot of what it looks like in the CMS to the readme.md?

Getting deprecation warning when displaying a field without content in template.

I could extend the Config class to have my own toolbar config, or to disable the toolbar, however, other options such as for the status bar or the spell checker are one level above the toolbar in the simpleMDE configuration in javascript.

In the file vendor/silverstripers/markdown/client/src/components/MarkdownEditorField/MarkdownEditorField.js on line 157 every other option such as spellChecker: false won't reach the simpleMDE options.

It would be nice to be able to pass higher level configuration options as defined here:
https://github.com/sparksuite/simplemde-markdown-editor#configuration

Version: 2.0.0
CMS Version 4.3.0
Tested browser: chrome/firefox

Error Description:
Clicking on the "insert image" or "embed media" button throws a javascript error

vendor.js?m=1544502093:1 Uncaught Error: Could not find "store" in either the context or props of "Connect(t)". Either wrap the root component in a <Provider>, or explicitly pass "store" as a prop to "Connect(t)".
    at o (vendor.js?m=1544502093:1)
    at new a (vendor.js?m=1544502093:1)
    at c._constructComponentWithoutOwner (vendor.js?m=1544502093:1)
    at c._constructComponent (vendor.js?m=1544502093:1)
    at c.mountComponent (vendor.js?m=1544502093:1)
    at Object.mountComponent (vendor.js?m=1544502093:1)
    at c.performInitialMount (vendor.js?m=1544502093:1)
    at c.mountComponent (vendor.js?m=1544502093:1)
    at Object.mountComponent (vendor.js?m=1544502093:1)
    at c.performInitialMount (vendor.js?m=1544502093:1)

There are no unit tests. It would be good to get those up to improve on code quality and consistency.

Version 2.0.0 has framework requirements at ^4, in master branch it's 4.1.x-dev with a commit saying it's not compatible with SS 4.2.

Would it be possible to perhaps release a new major with the constraint relaxed back to ^4 or requiring ^4.3 or higher? Do we know what the issue was back in the day?

I have enabled to have Content always be a MarkDown Field, and get this error (I will investigate further later on, not really have time right now.)

Call to a member function getAttributes() on string in /vagrant/website/vendor/silverstripers/silverstripe-markdown/src/forms/MarkdownEditorField.php on line 64

To not have to write the FQN in $db, the field should be declared as in SilverStripe\Framework_config\model.yml

The javascript that's loaded in for SilverStripe 4 seems to not working anymore with the latest beta