helaili / github-oidc-auth-app Goto Github PK

Parsing error is not reported clearly. Such an error should be more obvious.

We should be able to figure out the installation id from the target org name. That would provide a better experience.

According to https://github.com/helaili/github-oidc-auth-app/blob/main/README.md#credits and verified by reviewing https://github.com/helaili/github-oidc-auth-app/blob/main/jwks.go code has indeed been re-used from https://github.com/github/actions-oidc-gateway-example project that is licensed under MIT license. Per MIT license your project should contain copyright notice of the original as Copyright (c) 2022 GitHub as well as your own copyright.

I am interested in reusing your project but wanted to make sure it was buttoned up from the legal standpoint. Let me know if a PR would be helpful.

Region currently fluctuates from one deployment to another, which leads to failures

For example to support deployment on Raspberry Pi or Oracle Cloud Free Tier (https://www.oracle.com/cloud/free/).

Let say I want to have a scale minimum to 2 on this service.
The webhook will trigger a cache reloading on 1 instance not the 2.

I see 3 ways resolving this problem:

• use an external tools to cache the policies
• use an external messaging tool to push a "reload" message listened by all the instance
• create a reload endpoint and make the instance receiving the event to trigger reload on all other instance via a call to the api. Instance resolution could be done via a DNS resolution for instance (headless service on kubernetes, entry in dns with a server pool... )

A dns solution would be like this:

if os.GetEnv("INSTANCES_LIST")!=nil {
        context := context.Background()
	res, err := net.DefaultResolver.LookupIP(context, "ip", os.GetEnv("INSTANCES_LIST"))
	if err != nil {
		log.Fatalf("No ip found for the given instance list %s", os.GetEnv("INSTANCES_LIST"), err)
	}
	for _, ip := range res {
		// Call the /resetCache endpoint to reset the cache
		_, err := http.Post(fmt.Sprintf("http://%s/resetCache", ip.String()), "application/json", nil)
		if err != nil {
			log.Fatalf("Instance with IP %s is in error", ip, err)
		}
	}
}
```

any thought on this ?

Some organizations might want to separate the config file from GitHub to ensure proper separation of concerns. This type of deployment could be an option as others might prefer the repo based experience.