Code Monkey home page Code Monkey logo

embetty's People

Contributors

ausminternet avatar bdeutsch-heise avatar benjaminherbert avatar compeak avatar danielruf avatar dependabot-preview[bot] avatar dependabot[bot] avatar greenkeeper[bot] avatar luto avatar maczarr avatar mick352 avatar mkramsconnectaag avatar mndys avatar pmb0 avatar rbraband avatar schliflo avatar semantic-release-bot avatar stevenkowalzik avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

embetty's Issues

Tweet with Hashtags that contain Umlauts don't get completly linked

General information

  • embetty version: 1.1.2
  • Node.js version: Supplied by Official Docker image
  • Operating system name and version: Ubuntu 18.04
  • Browser name and version: Firefox 61.0.1 (64-Bit)

Steps to reproduce the behaviour

Embedding a Tweet that contains one or more hashtags with german Umlauts.
E.g. #stadtköln

Expected behaviour

The whole hashtag gets linked to https://twitter.com/hashtag/stadtköln

<a href="https://twitter.com/hashtag/stadtköln" class="style-scope embetty-tweet">#stadtköln</a>

Actual behaviour

<a href="https://twitter.com/hashtag/stadt" class="style-scope embetty-tweet">#stadtk</a>oeln

Thea hrefends at "stadtk": https://twitter.com/hashtag/stadtk

Fix suggestion:

Change the Regex in embetty.js from

return this._data.full_text.replace(/#(\w+)/g, function (hashTag, word) {
return '<a href="https://twitter.com/hashtag/' + word + '">' + hashTag + '</a>';

to maybe something like: #([A-Za-z0-9_äÄöÖüÜß]+)

return this._data.full_text.replace(/#([A-Za-z0-9_äÄöÖüÜß]+)/g, function (hashTag, word) {
return '<a href="https://twitter.com/hashtag/' + word + '">' + hashTag + '</a>';

An in-range update of husky is breaking the build 🚨

The devDependency husky was updated from 4.2.1 to 4.2.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

husky is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v4.2.2
  • Fix #662 disable fast-skip heuristic for .husky.js and .husky.config.js
  • Fix do not install update, pre/post-receive hooks
Commits

The new version differs by 7 commits.

  • c16aa78 4.2.2
  • 9e65360 update snapshot
  • 015f3aa fix husky.sh syntax error
  • 7791433 Fix #662 disable fast-skip heuristic for .husky.js and .husky.config.js
  • 7e79d16 Fix: do not install server hooks
  • b05fe3b Added husky.config.js (#595)
  • 2998c95 Update README.md

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Version 10 of node.js has been released

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

  • Added the new Node.js version to your .travis.yml

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

More information on this issue

Greenkeeper has checked the engines key in any package.json file, the .nvmrc file, and the .travis.yml file, if present.

  • engines was only updated if it defined a single version, not a range.
  • .nvmrc was updated to Node.js 10
  • .travis.yml was only changed if there was a root-level node_js that didn’t already include Node.js 10, such as node or lts/*. In this case, the new version was appended to the list. We didn’t touch job or matrix configurations because these tend to be quite specific and complex, and it’s difficult to infer what the intentions were.

For many simpler .travis.yml configurations, this PR should suffice as-is, but depending on what you’re doing it may require additional work or may not be applicable at all. We’re also aware that you may have good reasons to not update to Node.js 10, which is why this was sent as an issue and not a pull request. Feel free to delete it without comment, I’m a humble robot and won’t feel rejected 🤖


FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Embetty-Mastodon not working

I have a working Embetty-instance for years with my Wordpress-Blog. Now I want to update to embed Mastodon-posts.

General information

  • embetty version: 3.2.5
  • embetty.js version: 4.0.0
  • Node.js version: 18.19,0
  • Operating system name and version: Debian Bookworm
  • Browser name and version: Firefox 123.0.1

Steps to reproduce the behaviour

I updated the docker-component and the embetty.js
Embetty is working for Youtube-videos.

Expected behaviour

I added something like this:

and the Toot should be displayed.

Actual behaviour

The Toot is not displayed.

Image Cut on left and right size

Browser: Firefox

When reading your article (https://www.heise.de/newsticker/meldung/Embetty-Social-Media-Inhalte-datenschutzgerecht-einbinden-4060362.html ), I noticed that the image was slightly cut on the left and right side. This was espcially visible on the heise-E (see screenshot).

The issues is a result of the CSS rule

embetty-tweet #media.embetty-tweet img.embetty-tweet {
    ...
    -o-object-fit: cover;
    object-fit: cover;

}

which is also included twice one the page

grafik

An in-range update of @webcomponents/webcomponentsjs is breaking the build 🚨

The devDependency @webcomponents/webcomponentsjs was updated from 2.4.1 to 2.4.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@webcomponents/webcomponentsjs is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • Test: There are 1 failures, 10 warnings, and 0 notices.

Commits

The new version differs by 52 commits.

  • fd0ebcd Publish
  • 1aaead3 Merge pull request #274 from webcomponents/ce-externs-license-header
  • 5535da1 Add license header to Externs.ts
  • bb73aa2 Merge pull request #272 from webcomponents/remove-extra-externs
  • eafcc1f Remove externs that aren't used internally.
  • e8c8620 Merge pull request #270 from webcomponents/detect-forks
  • c8296d7 Fix detection of forked PRs in testing GitHub action
  • 73f52e0 Merge pull request #246 from rictic/ts-custom-elements
  • 650a5c2 Address final review.
  • 6aa0226 Merge pull request #267 from webcomponents/fix-266
  • 84fdf87 Merge pull request #263 from webcomponents/sd-event-properties-source
  • a82534f Simplfy logic based on review feedback
  • e5673be Correctly detect slot.insertBefore as requiring shadowRoot distribution
  • ae9ec7e Use Array instead of T[] consistently.
  • cf8ce37 Use a branded unconstructable type rather than unique symbol to save bytes.

There are 52 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of babel7 is breaking the build 🚨

There have been updates to the babel7 monorepo:

    • The devDependency @babel/core was updated from 7.7.7 to 7.8.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the babel7 group definition.

babel7 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of regenerator-runtime is breaking the build 🚨


☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The dependency regenerator-runtime was updated from 0.13.4 to 0.13.5.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

regenerator-runtime is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • Test: There are 1 failures, 10 warnings, and 0 notices.

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Extend documentation for event usage

General information

  • embetty version: v1.0.5
    No further information required.

I was looking for a way to check if embetty started successfully and found that event :)
It would be good if there was a reference in the documentation to the use of the'initialized' event with code example.

$('embetty-video').on("initialized", function () { //your code here });

Additionally I would suggest an event after clicking on'playButton' ->'activated'.

Pull request: #29

Steps to reproduce the behaviour

Click on 'playButton'

Expected behaviour

Emit event 'activated'

$('embetty-video').on("activated", function () { //your code here });

Actual behaviour

NOP

An in-range update of puppeteer is breaking the build 🚨

The devDependency puppeteer was updated from 2.0.0 to 2.1.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

puppeteer is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 21 commits.

  • a30cf05 chore: mark version v2.1.0 (#5347)
  • 013a86c feat(chromium): roll Chromium to r722269 (#5289)
  • 14b2369 chore: mark puppeteer-firefox version v0.5.1 (#5294)
  • 3a49cfc chore: move to GitHub hosting for Juggler binaries (#5293)
  • c7af7de docs(readme): update link for ndb (#5272)
  • 5e63254 chore: fix typo in test name (#5217)
  • 80b5c44 chore: upgrade https-proxy-agent (#5243)
  • 6091a34 fix: prepare jsHandle.uploadFile for CDP Page.handleFileChooser removal (#5196)
  • 8b49dc6 fix: don’t disable BlinkGenPropertyTrees anymore (#5159)
  • f0bf645 test: reduce flakiness for accessibility tests with autofocus (#5116)
  • 6cc98a7 docs(troubleshooting): recommend using args for heroku (#5197)
  • 35d5ba5 feat(launcher): Set default Firefox prefs (#5149) (#5195)
  • eddb23b chore: update URLs (#5185)
  • c5a72e9 feat(launcher): add option to run Puppeteer with different browsers (#5137)
  • d17708b fix(types): publish protocol types to npm (#5174)

There are 21 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of file-loader is breaking the build 🚨

The devDependency file-loader was updated from 4.1.0 to 4.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

file-loader is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Release Notes for v4.2.0

4.2.0 (2019-08-07)

Features

Commits

The new version differs by 3 commits.

  • ba0fd4c chore(release): 4.2.0
  • 642ee74 docs: improve readme (#341)
  • c136f44 feat: postTransformPublicPath option (#334)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of css-loader is breaking the build 🚨

The devDependency css-loader was updated from 3.3.2 to 3.4.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

css-loader is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v3.4.0

3.4.0 (2019-12-17)

Features

Bug Fixes

  • logic for order and media queries for imports (#1018) (65450d9)
Commits

The new version differs by 9 commits ahead by 9, behind by 2.

  • b95a779 chore(release): 3.4.0
  • 63a74b2 chore(deps): update (#1027)
  • 796fe28 Test more (#1024)
  • d358cdb feat: esModule option (#1026)
  • 23bc1e9 refactor: code
  • 0016e49 test: webpack5 (#1023)
  • ea26c56 test: refactor
  • ee40727 chore(defaults): update (#1020)
  • 65450d9 fix: logic for order and media queries for imports (#1018)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of webpack-bundle-analyzer is breaking the build 🚨


☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The devDependency webpack-bundle-analyzer was updated from 3.6.0 to 3.6.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

webpack-bundle-analyzer is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • Test: There are 1 failures, 10 warnings, and 0 notices.

Commits

The new version differs by 17 commits.

  • 660dba6 v3.6.1
  • 387d7f9 Merge pull request #339 from webpack-contrib/update-some-deps
  • e90b3b1 Downgrade terser-webpack-plugin because v2 requires at least Node v8.9
  • 45ffbf9 Update some dependencies to get rid of vulnerability warnings
  • dd4a03a Merge pull request #328 from pustovalov/node-ci
  • f2f7fda Add Node 12 to CI
  • 7cefb58 Merge pull request #314 from mhxbe/bugfix/page-title-hours-minutes
  • 2596783 Consolidate changelog whitespace
  • 3faca9d Merge branch 'master' into bugfix/page-title-hours-minutes
  • f614bd1 Update CHANGELOG.md
  • 4b58fae Revert .padStart to .slice since padStart is not supported in Node v6
  • c95df99 Fix changelog missing v3.6.0 section
  • f04ab3e Use .padStart(2,0) to prefix one-digit numbers with zero
  • 5219462 Merge branch 'bugfix/page-title-hours-minutes' of github.com:mhxbe/webpack-bundle-analyzer into bugfix/page-title-hours-minutes
  • 27b2de0 Use .slice() in favor of soon to be deprecated .substr()

There are 17 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of karma is breaking the build 🚨

The devDependency karma was updated from 3.1.1 to 3.1.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

karma is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v3.1.2

Bug Fixes

Features

Commits

The new version differs by 11 commits.

  • 7d4d347 chore: release v3.1.2
  • 5077c18 chore: update contributors
  • fb05fb1 fix(server): use flatted for json.stringify (#3220)
  • 2682bff feat(docs): callout the key debug strategies. (#3219)
  • 4e87902 fix(changelog): remove release which does not exist (#3214)
  • 30ff73b fix(browser): report errors to console during singleRun=false (#3209)
  • 5334d1a fix(file-list): do not preprocess up-to-date files (#3196)
  • dc5f5de fix(deps): upgrade sinon-chai 2.x -> 3.x (#3207)
  • d38f344 fix(package): bump lodash version (#3203)
  • ffb41f9 refactor(browser): log state transitions in debug (#3202)
  • 240209f fix(dep): Bump useragent to fix HeadlessChrome version (#3201)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of webpack is breaking the build 🚨

The devDependency webpack was updated from 4.41.6 to 4.42.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

webpack is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • Test: There are 1 failures, 10 warnings, and 0 notices.

Release Notes for v4.42.0

Bugfixes

  • Disable constant replacements in "use asm" scope
  • Update schema to disallow functions for output.hotUpdateChunkFilename as this doesn't work
  • Hoist exports in concatenated module to handle circular references with non-concatenated modules correctly
  • Flag all modules as used in DLLs to fix missing exports
Commits

The new version differs by 11 commits.

  • 29d851b 4.42.0
  • 07a4b28 Merge pull request #10478 from webpack/bugfix/all-modules-dll
  • c1aa9d4 flag all modules as used for Dll
  • d147689 Merge pull request #10431 from webpack/bugfix/concat-circular-4
  • d76761d hoist exports to the top of a concatenated module
  • 534d78f Merge pull request #10393 from webpack/schema/disallow-function-hotchunkfilename
  • d46ddc2 disallow function for output.hotUpdateChunkFilename
  • 95409bd Merge pull request #10294 from ngg/asmjs-4
  • 7a30012 spacing
  • 284e97f add detectStrictMode method for backward-compat
  • a7a07bc do not evaluate constants in asm.js, fix IIFE mode detection

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Missing dist folder

General information

  • embetty version: 1.0.4
  • Operating system name and version: ubuntu 16.04
  • Browser name and version: Opera 53

Steps to reproduce the behaviour

I downloaded 1.0.4 from the release page and tried to follow the instructions (option 1) to setup a sample page.
There is no ./dist/embetty.js that is mentioned in the docs.
Including ./lib/embetty.js results in "Uncaught SyntaxError: Unexpected string" in opera + chrome. So the ./lib/embetty.js is obviously not the correct one.

The example pages reference a embetty.js that is also not available.

I did not try the other 2 options as I do not have a suitable dev environment.

So what am I missing?

Use embetty to embed interactive (leaflet-) maps?

Hello, I would like to embed a dynamic geographic map on my webpage with some kind of two click solution,
so that the users are asked before open street map data (or other background layer data) is loaded from external servers.

=> Is embetty the right tool to wrap dynamic maps?

a) If so, is there some example available?

b) If not, is there some alternative solution you would recommend?

An in-range update of eslint-plugin-jest is breaking the build 🚨

The devDependency eslint-plugin-jest was updated from 23.7.0 to 23.8.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-jest is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v23.8.0

23.8.0 (2020-02-23)

Bug Fixes

  • valid-title: ensure argument node is defined before accessing props (#538) (7730f75)

Features

  • no-large-snapshots: add setting to define maxSize by snapshot type (#524) (0d77300)
Commits

The new version differs by 6 commits.

  • adc3b2e chore(release): 23.8.0 [skip ci]
  • 0d77300 feat(no-large-snapshots): add setting to define maxSize by snapshot type (#524)
  • 7730f75 fix(valid-title): ensure argument node is defined before accessing props (#538)
  • 5d8be9d chore: fix parameter name typo (#537)
  • 6507a7a chore: simplify getNodeName (#536)
  • 7becf4a chore: remove duplicated interface (#535)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of webpack-cli is breaking the build 🚨

The devDependency webpack-cli was updated from 3.3.2 to 3.3.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

webpack-cli is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 201 commits.

  • 173d11a chore: v.3.3.3
  • 7071b5c misc: update internal docs
  • 69f7683 chore: monorepo version update
  • efe8c2a chore: update jest snapshots
  • 12a38be chore: monorepo version update
  • 2608179 chore: lockfile updates
  • 25c6e7b chore: v.3.2.2 until mnorepo versioning
  • 67b3dc7 chore: update utils version for init pkg
  • ace0d4a chore: monorepo version update
  • 5c8c6a1 misc: add lerna publish cmnd
  • 16079a1 chore: lerna independent
  • b9711e8 chore: sec fixes
  • 9b78911 chore: sec patch monorepo
  • d577b0c chore: v.3.3.3
  • 4b08819 Merge pull request #925 from anshumanv/prettier/format

There are 201 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

MS Edge not working

General information

  • embetty version: v1.0.5
  • Node.js version: v8.9.4
  • Operating system name and version: Win10 Pro 1703
  • Browser name and version: Microsoft Edge 40.15063.674.0

Steps to reproduce the behaviour

  1. Install the embetty-server and the demo page
  2. Open with browser Edge

image

Expected behaviour

Working like a charm .. Chrome and FF

Actual behaviour

Not working with MS Edge

Breaks Promises from unrelated JavaScript code

General information

  • embetty version: v1.0.6
  • Node.js version: build of embetty.js created with v10.5.0
  • Browser name and version: all browsers that don't natively support Shadow DOM, for example Firefox v60

Steps to reproduce the behaviour

Create a build of embetty and add it to a web project (in this case a Ruby on Rails project, but should be irrelevant) that is running unrelated JavaScript code which makes use of Promises.

Expected behaviour

Embetty should stay in its lane. No error should occur.

Actual behaviour

Embetty tries to resolve Promises from unrelated parts of the codebase, then throws an error because it doesn't know what to do with the result of the Promise. Happens only in browsers listed above.

One example from our image lazy loading logic is:

SyntaxError: '[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement],[object HTMLImageElement]' is not a valid selector

As far as we have been able to debug this issue, this is caused by the shadydom code that is bundled with embetty as part of the webcomponents polyfill. And so this issue only occurs in browsers that don't natively support Shadow DOM.

We can't determine why it would do that or how it does that. We can't even determine which part of the code does it, since all embetty dependencies are transpiled/minified, even when we debugged the issue with a not-transpiled/not-minified test-build of embetty. We just saw that the error occurred in the webcomponent polyfill part of the code.

YouTube Playlist

Hi dear Embetty team,

is it possible to use Embetty with YouTube playlists?

Thanks und best
Andreas

An in-range update of cache-loader is breaking the build 🚨

The devDependency cache-loader was updated from 1.2.3 to 1.2.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

cache-loader is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v1.2.4

2018-10-31

Bug Fixes

  • index: fallback to fs if this.fs is undefined (#45) (b84d13e)
Commits

The new version differs by 3 commits.

  • 97be0c1 chore(release): 1.2.4
  • 6c7361d style(index): lint
  • b84d13e fix(index): fallback to fs if this.fs is undefined (#45)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of webpack-dev-server is breaking the build 🚨

The devDependency webpack-dev-server was updated from 3.7.2 to 3.8.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

webpack-dev-server is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v3.8.0

3.8.0 (2019-08-09)

Bug Fixes

  • server: fix setupExitSignals usage (#2181) (bbe410e)
  • server: set port before instantiating server (#2143) (cfbf229)
  • check for name of HotModuleReplacementPlugin to avoid RangeError (#2146) (4579775)
  • server: check for external urls in array (#1980) (fa78347)
  • server: fix header check for socket server (#2077) (7f51859)
  • server: stricter headers security check (#2092) (078ddca)

Features

Potential Breaking Changes

We have migrated serverMode and clientMode to transportMode as an experimental option. If you want to use this feature, you have to change your settings.

Related PR: #2116

Commits

The new version differs by 65 commits.

  • 84cb481 chore(release): 3.8.0
  • b5b9cb4 feat(server): add transportMode (#2116)
  • 460f15a test(e2e): More e2e test improvements (#2163)
  • bc7005e chore(deps): update dependency husky to ^3.0.3 (master) (#2182)
  • bbe410e fix(server): fix setupExitSignals usage (#2181)
  • 21e7646 chore(deps): update dependency style-loader to v1 (#2179)
  • a28800d chore(deps): update [email protected] (#2176)
  • 68a1f29 chore(deps): update webpack to 4.39.0 (#2171)
  • c2da532 chore(deps): update dependency standard-version to v7 (#2160)
  • 18edd18 refactor: simplify (#2120)
  • cfbf229 fix(server): set port before instantiating server (#2143)
  • f80e2ae chore(babel): use api.cache (#2157)
  • 0de4eba chore(deps): update all patch dependencies (#2159)
  • 1f9f9dc test(utils): increase coverage (#2156)
  • 9c171d1 chore(deps): update all patch dependencies (master) (patch) (#2151)

There are 65 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Twitter links no longer work in "new Twitter"

Twitter currently advertises "Sneak a peek at the new Twitter" on its home page, giving its users the opportunity to try out their new layout.

As soon as a user activates it, the embetty-generated links in the form of

https://twitter.com/statuses/<tweet-id>

no longer work; they lead to a "Page not found" error on Twitter's site.

I have found that the link form of

https://twitter.com/<username>/status/<tweet-id>

seems to work in both "new Twitter" as well as in "legacy Twitter" (as Twitter calls it), so it might be a good idea to change the format returned by twitterUrl(). That format is the same that Twitter itself provides through its "Copy link to tweet" functionality so I regard it as official and stable.

An in-range update of babel7 is breaking the build 🚨

There have been updates to the babel7 monorepo:

    • The devDependency @babel/core was updated from 7.8.4 to 7.8.6.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the babel7 group definition.

babel7 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • Test: There are 1 failures, 10 warnings, and 0 notices.

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of webpack is breaking the build 🚨

The devDependency webpack was updated from 4.41.5 to 4.41.6.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

webpack is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v4.41.6

Bugfixes

  • Windows network paths are considered as absolute paths
  • fix hanging of FlagDependencyExportsPlugin when using export * in a circular matter
Commits

The new version differs by 12 commits.

  • 71be3bf 4.41.6
  • 0b8ef22 Merge pull request #10344 from webpack/bugfix/hang-circular-reexport
  • 614ea54 only retrigger flagging exports in dependencies when exports really changed
  • 627510d Merge pull request #10255 from jeffin143/fix-10247
  • e826575 correct windows paths must use \ and not /
  • 5e9f083 Merge pull request #10240 from jeffin143/fix-10217
  • d8c74b6 fix: better handle absolute paths
  • ef73991 update webpackOption.d.ts
  • 2101892 add chunkid declaration
  • 4bb706f Fix lint issue
  • 2394136 added variable declarations in files where required
  • 148c4be get rid of some hacks in declarations file for webpack-4

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of webpack is breaking the build 🚨

The devDependency webpack was updated from 4.19.0 to 4.19.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

webpack is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v4.19.1

Bugfixes

  • Internal requested filename for import() with target: "electron-main" uses correct path separator on windows
    (This fixes a problem with filemappings in vscode)
  • devtool: "source-map" and variants generate SourceMaps when output file is .mjs
  • browser field as object is used when using target: "electron-renderer"
  • Comments near export default are preserved
  • Passing an array as externals value, now works correctly as documented
Commits

The new version differs by 15 commits.

  • b7121c1 4.19.1
  • ab28497 Merge pull request #8043 from RubenVerborgh/externals-object-array
  • 9bda629 remove bad unit test
  • f0271d9 fix ExternalModule and test case
  • 3aef0e5 Allow array as value in externals object.
  • 7b91fa6 Merge pull request #8042 from webpack/bugfix/comments-export-default
  • e08f71c keep/restore comments in export default
  • 2f78aae Merge pull request #8038 from sharang-d/patch-5
  • bb4c2d1 Correctly set the 'browser' value for electron-renderer
  • 5ade574 Merge pull request #7947 from philipwalton/mjs-sourcemap-support
  • 5258471 Merge pull request #8035 from kwonoj/fix-path
  • 2df7b0c fix(nodemaintemplate): resolve async chunk path platform agnostic
  • 17fafd3 Fix lint errors
  • a2cc031 Add tests for default source map extensions
  • 12762ff Add sourcemap support for .mjs output files

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

add twitch support

This is a feature request: It would be great, if I there would be twitch support for embedding clips, videos and livestreams

Youtube tracked on demo page

General information

  • embetty version: Latests on Demo Page
  • Node.js version: ...
  • Operating system name and version: Mac OSX
  • Browser name and version: Firefox & Latest

Steps to reproduce the behaviour

Load the demo page, press play on the youtube video.
Notice one of the calls to youtube includes a cookie

Expected behaviour

I did not expect to be tracked.

Actual behaviour

Here is an example of the tracking that happens. I have inserted <private> in places where it seems that an identifier might have been.

GET /api/stats/watchtime?ns=yt&el=embedded&cpn=<private>&docid=m6UOo2YGbIE&ver=2&referrer=https%3A%2F%2Fwww.youtube.com%2Fembed%2Fm6UOo2YGbIE%3Fautoplay%3D1&cmt=2.461&plid=AAVuCz9Dj9FZjI_Z&ei=PBEZW8maIY-F7QSIyp3ACw&fmt=135&fs=0&rt=8.003&of=up5AJuQ323o9cdDjlC2o8g&euri=https%3A%2F%2Fheiseonline.github.io%2Fembetty%2F&lact=2734&cl=199484561&state=paused&vm=CAEQARgE&volume=45&c=WEB_EMBEDDED_PLAYER&cver=20180606&cplayer=UNIPLAYER&cbr=Firefox&cbrver=60.0&cos=Macintosh&cosver=10.13&autoplay=1&hl=en_US&cr=DK&len=35550.678&rtn=18&afmt=140&idpj=-4&ldpj=-7&rti=8&muted=0&st=0&et=2.461&au=und.4 HTTP/1.1
Host: www.youtube.com
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Firefox/60.0
Accept: */*
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate, br
Referer: https://www.youtube.com/embed/m6UOo2YGbIE?autoplay=1
Cookie: SID=<private>; HSID=<private>; SSID=<private>; APISID=<private>; SAPISID=<private>; CONSENT=YES+<private>; VISITOR_INFO1_LIVE=<private>; PREF=f1=50000000; LOGIN_INFO=<private>; YSC=<private>; GPS=1
Connection: keep-alive
Pragma: no-cache
Cache-Control: no-cache

An in-range update of webpack is breaking the build 🚨

The devDependency webpack was updated from 4.35.3 to 4.36.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

webpack is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Release Notes for v4.36.0

Features

  • SourceMapDevToolPlugin append option now supports the default placeholders in addition to [url]
  • Arrays in resolve and parser options (Rule and Loader API) support backreferences with "..." when overriding options.
Commits

The new version differs by 42 commits.

  • 95d21bb 4.36.0
  • aa1216c Merge pull request #9422 from webpack/feature/dot-dot-dot-merge
  • b3ec775 improve merging of resolve and parsing options
  • 53a5ae2 Merge pull request #9419 from vankop/remove-valid-jsdoc-rule
  • ab75240 Merge pull request #9413 from webpack/dependabot/npm_and_yarn/ajv-6.10.2
  • 0bdabf4 Merge pull request #9418 from webpack/dependabot/npm_and_yarn/eslint-plugin-jsdoc-15.5.2
  • f207cdc remove valid jsdoc rule in favour of eslint-plugin-jsdoc
  • 31333a6 chore(deps-dev): bump eslint-plugin-jsdoc from 15.3.9 to 15.5.2
  • 036adf0 Merge pull request #9417 from webpack/dependabot/npm_and_yarn/eslint-plugin-jest-22.8.0
  • 37d4480 Merge pull request #9411 from webpack/dependabot/npm_and_yarn/simple-git-1.121.0
  • ce2a183 chore(deps-dev): bump eslint-plugin-jest from 22.7.2 to 22.8.0
  • 0beeb7e Merge pull request #9391 from vankop/create-hash-typescript
  • bf1a24a #9391 resolve super call discussion
  • bd7d95b #9391 resolve discussions, AbstractMethodError
  • 4190638 chore(deps): bump ajv from 6.10.1 to 6.10.2

There are 42 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Low quality and distorted aspect ratio of the preview image in versions starting from 3.0.0 for at least youtube videos

Up to version 2.0.3 of the embetty server, the preview image of a youtube video was rendered fine, showing the preview image with the "native" resolution and aspect ratio of the video.

From version 3.0.0 on, it seems that the preview image is forced to a resolution of 480 x 360 px with an aspect ratio of 4:3, which leads to a distorted and low quality preview.

General information

  • embetty version: 2.0.3 vs. 3.0.0 and up
  • Node.js version: image from docker hub
  • Operating system name and version: docker
  • Browser name and version: chrome, firefox, safari, edge

Steps to reproduce the behaviour

Embed a youtube video for use with embetty, e.g. RvpudFBKUbo

Expected behaviour

The preview image rendered should have a resolution of 1280 x 720 px as with embetty server up to 2.0.3

screenshot-embetty-server-2-0-3

Actual behaviour

The preview image has a resolution of 480 x 360 px (aspect ratio 4:3) from embetty server starting with version 3.0.0 which leads to a distorted and low resolution up scaled image which looks ugly

screenshot-embetty-server-3-0-0

embetty logo display broken in versions 1.17 & later

after upgrading raw-loader in 1.17 to the most recent version, the embetty logo o top of the embedded media does not show in the browser anymore. this is because raw-loaderintroduced a breaking change in v2. I further explained in PR #80.

An in-range update of core-js is breaking the build 🚨

The dependency core-js was updated from 3.5.0 to 3.6.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

core-js is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for 3.6.0 - 2019.12.19
  • Added support of sticky (y) RegExp flag, #372, #732, #492, thanks @cvle and @nicolo-ribaudo
  • Added RegExp#test delegation to RegExp#exec, #732, thanks @cvle
  • Fixed some cases of Object.create(null) in IE8-, #727, #728, thanks @aleen42
  • Allowed object of minimum environment versions as core-js-compat and core-js-builder targets argument
  • Allowed corresponding to Babel targets.esmodules, targets.browsers, targets.node options in core-js-compat and core-js-builder
  • Engines in compat data and results of targets parsing sorted alphabetically
  • Fixed features/instance/match-all entry compat data
  • Fixed Array.prototype[@@unscopables] descriptor (was writable)
  • Added Samsung Internet 11 compat data mapping
FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of webpack-dev-server is breaking the build 🚨

The devDependency webpack-dev-server was updated from 3.10.1 to 3.10.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

webpack-dev-server is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v3.10.2

3.10.2 (2020-01-31)

Bug Fixes

  • fallthrough non GET and HEAD request to routes (#2374) (ebe8eca)
  • add an optional peer dependency on webpack-cli (#2396) (aa365df)
  • add heartbeat for the websocket server (#2404) (1a7c827)
Commits

The new version differs by 16 commits ahead by 16, behind by 2.

  • 5aa86b5 chore(release): 3.10.2
  • 1a7c827 fix: add heartbeat for the websocket server (#2404)
  • 0325b01 chore(deps): update all patch dependencies (#2412)
  • 7852f05 chore(deps): update dependency lint-staged to v10 (#2397)
  • 43e8c24 chore(deps): update all patch dependencies (#2394)
  • d7ebf19 chore(deps): update all minor dependencies (#2390)
  • aa365df fix: add an optional peer dependency on webpack-cli (#2396)
  • f9937f5 chore(deps): update all patch dependencies to ^8.3.4 (#2382)
  • a1d28c0 chore(deps): update all patch dependencies (master) (patch) (#2372)
  • f671241 chore(deps): update all minor dependencies (master) (minor) (#2375)
  • ebe8eca fix(server): fallthrough non GET and HEAD request to routes… (#2374)
  • f4c8f94 chore(deps): update dependency eslint-config-prettier to ^6.8.0… (#2371)
  • 453b41e chore(deps): update all minor dependencies (master) (minor) (#2366)
  • ff3dfbc chore(deps): update all patch dependencies (#2367)
  • 699404b fix: ie11 compatibility (#2364)

There are 16 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.