Code Monkey home page Code Monkey logo

Comments (11)

carlosantoniodasilva avatar carlosantoniodasilva commented on May 15, 2024

It might be a Chrome and/or Safari issue to not accept float elements in input type "number", but we'd have to take a look at the html5 specification to see how they should handle that. If you don't want "number" to be rendered, you can update it by passing the following option to your input:

:input_html => { :type => 'text' }

This would render an input type text instead of number.

from simple_form.

rafaelss avatar rafaelss commented on May 15, 2024

I had a problem with type="number" field too, but the field here is an integer, not float.
in chrome it shows up like that: http://cl.ly/6906ea16a2166174fc6f (in a form creating a new record)

using

:input_html => { :type => 'text' }

it works fine

from simple_form.

Baael avatar Baael commented on May 15, 2024

@rafaelss set it value to 0 if field value is not passed or isn't an integer

from simple_form.

rafaelss avatar rafaelss commented on May 15, 2024

@Baael I think would be good if simple_form could handle this, there will cases where it might have lots of integer fields and set 0 for all of them looks a bit "ugly" for me :)

from simple_form.

carlosantoniodasilva avatar carlosantoniodasilva commented on May 15, 2024

Guys, it seems more to be a Chrome/Safari issue, handling these inputs type=number wrong. I don't think that setting a default value to these attributes is a valid case for SimpleForm, as we shouldn't touch the given value. It's more likely to be a case to add default values for models or pass them straight to inputs. Might we have another way to solve it?

from simple_form.

carlosantoniodasilva avatar carlosantoniodasilva commented on May 15, 2024

Closing as won't fix, if you think this is still an issue with SimpleForm, please reopen.

from simple_form.

fringd avatar fringd commented on May 15, 2024

this should be re-opened...

http://dev.w3.org/html5/spec-author-view/common-input-element-attributes.html#attr-input-step

if you are going to specify the input as a number, you must specify the "step" attribute, or else the default of 1 will be used (i.e. integer) Right now only a few browsers implement this right, but some do, so we need to have type=number, step=any for our floats.

note that the step=any gives us free reign to specify it to thousandths, millionths, or whatever...

from simple_form.

carlosantoniodasilva avatar carlosantoniodasilva commented on May 15, 2024

SimpleForm in master branch already sets the default step attribute to "any" for non-integer columns, as you can see in 5aa4320. Expect a new release soon.

from simple_form.

fringd avatar fringd commented on May 15, 2024

http://dev.w3.org/html5/spec-author-view/number-state.html#number-state

has more relevant information....

from simple_form.

fringd avatar fringd commented on May 15, 2024

ah, ok. my fault for not checking master. I'm pulling from git for now, thanks :)

from simple_form.

carlosantoniodasilva avatar carlosantoniodasilva commented on May 15, 2024

No problem. Let us know if it works fine for you =).

On Tue, May 3, 2011 at 4:35 PM, fringd <
[email protected]>wrote:

ah, ok. my fault for not checking master. I'm pulling from git for now,
thanks :)

Reply to this email directly or view it on GitHub:
#41 (comment)

At.
Carlos A. da Silva

from simple_form.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.