heartbeatmaker / tensorflow-gpu Goto Github PK

(edit: sorry - I thought this was tensorflow-gpu's fork. ignore this issue)

hello! this is some passer-by's advice:

I noticed that you pushed a none-tensorflow code:

b7844c7

few notes:

• this is somewhat outside of what tensorflow have to do, and it's better to put this to your own project / library.
  • otherwise, you'll have to keep maintaining your branch while the original repo's master-branch gets updated.
  • if this is going to become a library, try to generalize things (and remove app-specific things)
• use async network (eg. select(), etc): socket.recv(65535) blocks the whole thread until receiving a packet
• use proper encoding/decoding or RPC framework with code-generation
  • see flatbuffers / protobuf / grpc / etc
  • little-mistakes sometimes result in sleepless nights / arguing...

anyway, sorry for the rant / long read.

have a good day~!