Code Monkey home page Code Monkey logo

Comments (6)

ihortymoshenko avatar ihortymoshenko commented on August 17, 2024

@rayrigam, thanks for an active contribution. I found at least one issue with paths that are actually URLs, not files in the local filesystem. The logic with checking each path as a file in the local filesystem was added with shim support, so I need some time in order to fix it. I also want to make some code refactoring for the namespace mapping. You should use the older version of the bundle, while I'll fix this issue.

from hearsayrequirejsbundle.

rayrigam avatar rayrigam commented on August 17, 2024

@IgorTimoshenko thanks for looking into this! I'll keep using the older version for now as you suggested. Best!

from hearsayrequirejsbundle.

ihortymoshenko avatar ihortymoshenko commented on August 17, 2024

@rayrigam, check your application please. I made the appropriate changes for the 1.0.x branch (the new one tag is currently not available until I'll be sure that all works ok) and for the 2.0.x branch with some refactorings. Thanks!

from hearsayrequirejsbundle.

rayrigam avatar rayrigam commented on August 17, 2024

@IgorTimoshenko thanks! I checked the new version and it works. It now takes the external URLs defined in the config paths and if it cannot find the asset at the first URL defined in the array, it uses the fallback. One thing to mention though is that for internal fallbacks to work, one needs to define the entire internal path (it does not use the base_directory defined in the config.yml file) as follows:

hearsay_require_js:
    base_directory: %kernel.root_dir%/../src/MyVendor/MyBundle/Resources/public/js
    paths:
        jquery:
            location: [//ajax.googleapis.com/ajax/libs/jquery/2.0.0/jquery.min, %kernel.root_dir%/../src/MyVendor/MyBundle/Resources/public/js/libs/jquery/2.0.0/jquery.min]
            external: true

from hearsayrequirejsbundle.

ihortymoshenko avatar ihortymoshenko commented on August 17, 2024

@rayrigam, yes, you're right but it's another issue that is related to the getRealPath method, so I close the current issue. Anyway, I know about it and I'll fix it in the nearest future.

from hearsayrequirejsbundle.

rayrigam avatar rayrigam commented on August 17, 2024

thanks!

from hearsayrequirejsbundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.