Code Monkey home page Code Monkey logo

Comments (7)

ihortymoshenko avatar ihortymoshenko commented on July 18, 2024

@houdmont, https://github.com/symfony/Config/blob/2.2/Definition/Builder/ArrayNodeDefinition.php#L310, since 2.2.

from hearsayrequirejsbundle.

houdmont avatar houdmont commented on July 18, 2024

Thank you,

Is it possible to state that fact in the dependencies?

The project I am currently working on is using v2.1 (which explains why I ended up with issues). I'm not sure if it's possible, but should composer.json state that symfony >= 2.2 is necessary?

from hearsayrequirejsbundle.

ihortymoshenko avatar ihortymoshenko commented on July 18, 2024

@houdmont, I'm not sure that's a good idea as I don't know how many people are using the old version.

from hearsayrequirejsbundle.

houdmont avatar houdmont commented on July 18, 2024

@IgorTimoshenko I can't understand why this would be a bad idea?

If someone is using an old version of Symfony, adding this requirement would prevent them from breaking projects when including the RequireJSBundle.

If someone is using an older version of the RequireJSBundle, then they won't be affected by the new dependency requirement added to the latest version of the bundle.

I'm probably misunderstanding something here though, so please explain if that's the case.

from hearsayrequirejsbundle.

ihortymoshenko avatar ihortymoshenko commented on July 18, 2024

@houdmont, yeah, you're right. I'll fix it.

from hearsayrequirejsbundle.

ihortymoshenko avatar ihortymoshenko commented on July 18, 2024

@houdmont, moreover, it makes sense to require "symfony/framework-bundle": ">=2.2.0".

from hearsayrequirejsbundle.

houdmont avatar houdmont commented on July 18, 2024

@IgorTimoshenko that's great! Thanks for helping, sorry I wasn't able to submit a pull request myself with a fix.

from hearsayrequirejsbundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.