hasura / codegen-assets Goto Github PK

When an action is derived from a Hasura operation, the generated code does not send request headers while delegating to the parent operation.

The json serialization doesn't handle lowercase/underscored column names when serializing to JSON. The struct fields are missing json tags to convert into lowercase. This might not really be a problem when GraphQL camelcase naming conventions are used, but databases might use lowercase/underscores by default.

type AutoGenerated struct {
	Name string `json:"name"`
}

https://github.com/hasura/codegen-assets/blob/master/builder-kit/src/languages-functional/go.ts#L25

The codegen looks like:

app.post((req, res) => {
  // hanler code
})

Most intuitive for any express developer to just copy and paste this in server.js.

Rename all Zeit string referrals to Vercel.

https://vercel.com/blog/zeit-is-now-vercel

These are the bunch of cases where codegen does incorrect things:

1. If the derived action returns an object but the parent operation returns a list, it causes runtime error.
2. If an action returns a list, codegen still returns just an object

When the Java Spring Boot code generator is being used, it does not create setters for the different fields in the classes. With that it is basically unusable, but of course devs can extend it if they want.

It would be better to have proper getter/setters for the fields in the different classes.

Example:

RestController looks fine:

package my_action;

    import java.util.List;

    import org.springframework.web.bind.annotation.PathVariable;
    import org.springframework.web.bind.annotation.PostMapping;
    import org.springframework.web.bind.annotation.RequestBody;
    import org.springframework.web.bind.annotation.RestController;

    @RestController
    class ActionController {
    @PostMapping("/getOrders")
    OrderQueryOutput handler(@RequestBody getOrdersArgs actionArgs) {
        // logic
    }
}

Generated classes not:

public class OrderQueryOutput {
  private Iterable<Order> _orders;
  public Iterable<Order> getorders() { return this._orders; }
}

public class Order {
  private String _orderId;
  public String getorderId() { return this._orderId; }
}

public class Query {
  private OrderQueryOutput _getOrders;
  public OrderQueryOutput getgetOrders() { return this._getOrders; }
}

public class getOrdersArgs {
  private ZonedDateTime _fromDate;
  public ZonedDateTime getfromDate() { return this._fromDate; }
  
  private ZonedDateTime _toDate;
  public ZonedDateTime gettoDate() { return this._toDate; }
}

The name of the class that is being used for the incoming parameters are also strange, but can work.

We can generate:

const {
  input: { arg1, arg2 },
  session_variables,
  action: { name: actionName }
} = req.body;

Currently we just generate:

const { arg1, arg2 } = req.body.input;

The codegen for error handling looks like this:

if (errors) {
    return res.status(400).json(errors[0])
}

This doesn't send the code received in the errors[0].extensions object and only sends the message. Ideally the codegen should send back the error code as it is to the client.

The updated error handling would look like this:

if (errors) {
    return res.status(400).json( { code: errors[0].extensions.code, message: errors[0].message } );
}

Latest version of codegen with documentation is available at: nodejs-azure/actions-codegen.js. Use that as a base.

Turns out nodejs-azure is a separate product on azure.

Actions support postgres scalars now (hasura/graphql-engine#4333).

This causes a problem in typescript codegen because graphql-code-generator expects the SDL to be complete in itself.

Currently we have a hack to make the codegen work. The SDL is parsed and the types not found in the SDL are manually added as scalars.

A better solution would be to take Hasura scalars as an argument for the code generator.

Spec for builder kit is already in the documentation: https://github.com/hasura/codegen-assets/blob/master/builder-kit/README.md#run-the-sample-codegen