runWithNewConnection action = do
      dbState :: PQ.DBState (Eff es) <- get
      result <- PQ.withConnection (PQ.unConnectionSource connectionSource) $ \newConn -> do
        put $ mkDBState newConn (PQ.dbTransactionSettings dbState)
        action
      put dbState
      pure result

If action throws and you catch the exception outside of withNewConnection, you'll be left with closed connection inside the DBState.

This needs bracket.

This is similar to #21. You'll only restore the original value of dbRecordLastQuery if action doesn't throw.

Hey,

Thanks for writing the adapter 🙂 I see it's rewriting methods of the typeclass instead of implementing them via the effect though.

For how it should be done please see haskell-effectful/crypto-rng-effectful#3.

If you provide the MonadDB instance and delegate to the effect, then all functions requiring the constraint will "just work" with the Eff monad. You will also not need qualified imports because there will be no name clashes.

If you look at runDBT, you'll see that it uses withTransaction if tsAutoTransaction is set. runEffectDB doesn't do that.

Same thing for withNewConnection.

You might need to copy/reimplement withTransaction 🤔

See this thread for details on what can be improved.

This is confusing since most of the functions from hpqtypes will throw HPQTypesError, but as a regular exception, which is different to the error handled by the Error effect (see https://hackage.haskell.org/package/effectful-core-1.1.0.0/docs/Effectful-Error-Static.html for more info).

I see that you've made GetConnectionStats use it, but it should just do what the original getConnectionStats implementation of DBT does.

🙂

Current CI job is too basic. The most important missing thing is lack of any caching.

I'd prefer to not maintain this by hand. The easiest approach is to use haskell-ci like the vast majority of the libraries we maintain do.

Example configuration can be found e.g. here.