harishanchu / nodejs-config Goto Github PK

Hi, it is a long shot and you probably don't maintain this repo anymore ( given last update was 5 years ago ) I really like the way Laravel handles configuration and wanted to use this in my project. When I set the NODE_ENV to development I get an error in index.js line 21 where you assign env parameter to either process.env.NODE_ENV or environmentDetector.

var env = process.env.NODE_ENV = environmentDetector.detect(environments);

if you have a chance to take a look, much appreciated. I feel like something like this may quickly resolve and I can submit a PR if you like

var env = process.env.NODE_ENV || environmentDetector.detect(environments);

Thank you for open sourcing this module.

A few comments:

1. It would be more useful and fit better within the Node community if you allowed the user to override the name of the config folder
2. It would be more intuitive to longtime Node programmers if process.env.NODE_ENV was the default. That is the environment value almost all popular modules use and is considered a best practice
3. In your README, it's unclear how your environment configuration object works. Is it specifying the machine names that, if matching the current machine, will indicate which environment the app will consider itself to be in?

I'm interested in using this module for a Netflix project if the above two changes were made. I'd be happy to open a pull request.