hapipal / tandy Goto Github PK

A call to /users/comments should get you all users with their comments.

Objection's insertGraph should make this pretty straightforward, though identifying relations could be tricky?

This npm package needs a TypeScript types declaration file so that developers who enjoy writing with TS can use it with this package and have a better development experience. Would you like me to write one?

Currently sort is dialect-specific (as it's being passed into the query as a raw string, therefore subject to dialects quoting rules) and being limited to one key

One idea that would work is to convert sort to accepting an array [[key, 'ASC/DESC']] and then iterate over that like this

const schema = Joi.array().items(Joi.array().ordered(Joi.string().valid('id', 'etc').required(), Joi.string().valid('asc', 'desc').default('asc')).required())
const { error, validated } = schema.validate(sortParam)

if (error) throw error

for (const sort of validated) {
  query = query.orderBy(sort[0], sort[1])
}

For backwards compatibility the new behaviour could be a flag or switched with sortParam.startsWith('[') (where the old schema is converted to the new one internally)

Bedwetter had a form of this, and now that I've decided not to port that functionality I've found a use-case for it.

Core hapi modules now live under the @Hapi namespace - update deps to reflect this.