hanwen / mftrace Goto Github PK

https://lilypond.org/downloads/sources/mftrace/mftrace-1.2.20.tar.gz

Missing: gf2pbm.1

#11 (comment)

.. so that fixes

• dd8dc8f
• 75c3d3c

arrive at end users everywhere. Thank you!

Hi Han-Wen,

Just updating the Debian package, and stumbled across two little bugs in the new version:

• GNUMakefile.in uses "echo -e" to generate the version.texi file. Unfortunately, that doesn't work correctly with all shells, and may result in "-e" appearing at the top of the README.txt file. Better is to replace "echo -e" with "printf".
• The VERSION setting in configure.in needs to be updated.

Best wishes,

Julian

Some versions of fontforge (e.g. the latest version 20120731) open a web browser not just for -usage but for -help, too. Despite their docs saying otherwise. Proof:

# strace -eprocess -F fontforge -help |& fgrep xdg-open
[pid  3966] execve("/bin/sh", ["sh", "-c", "\"xdg-open\" \"http://fontforge.sf."...], [/* 63 vars */]) = 0
execve("/usr/bin/xdg-open", ["xdg-open", "http://fontforge.sf.net/overview"...], [/* 61 vars */]) = 0

# fontforge -version
Copyright (c) 2000-2012 by George Williams.
 Executable based on sources from 14:57 GMT 31-Jul-2012.
 Library based on sources from 14:57 GMT 31-Jul-2012.
fontforge 20120731
libfontforge 20120731

While you could argue that the bug should be fixed in fontforge, there's an easy fix to make mftrace work for users of that fontforge version, too: I propose to turn the fontforge command detection from calling fontforge -usage to calling fontforge -version. Many thanks for your consideration.

Dear Han-Wen,

Thanks for mftrace! I am loving it. Here are my two cents: looks like mftrace 1.2.20 chokes on some files, e.g.:

sample.zip

The error:

s = (self.left[1:1 + b]).decode('ascii')
UnicodeDecodeError: 'ascii' codec can't decode byte 0xa0 in position 0: ordinal not in range(128)

The command was:

mftrace -f PFB zcmib5.mf

I’ve run this with mftrace 1.2.19, and all went smooth with that version.

Best regards!

The calls to p.add_option() for --potrace and --autotrace have no action attributes. Due to this some options are always set to defaults. My patch fixes this issue. Also, it removes redundant empty parameters for p.add_option() and fixes the issue with calling fontforge which now lacks -usage option.