hamedmasafi / gitklient Goto Github PK

Can you change to:

• KF5SyntaxHighlighting

• KF5::SyntaxHighlighting

Otherwise it doesn't build here.

Hello,

I am looking for packaging GitKlient for openSUSE and probably other distributions (yeah i know its in alpha/beta stage, but still, i am really amazed by the features, especially dolphin integration etc).
I have noticed, that you are providing .rpm packages. Can you please provide the .spec files used to build it, so I don't have to start from scratch?

Thanks!

This is not an issue, this is a "thank you" and "well done!" message

GitKlient builds just fine on FreeBSD, with the one fix for SyntaxHighlighting applied (see issue #5 ). I like it! The algorithm for drawing branches and merges is neat, somewhat different from other graphical Git clients I've seen. And it can deal with the convoluted 10000-commit history of Calamares without a hiccup. The 500000-commits of the FreeBSD ports collection are also loaded surprisingly quickly. Well done.

GitKlient requires the following versions, which are a weird mix. You might have special reasons for allowing / requiring them, but they are a bit peculiar.

• CMake 2.8.12 ; this is "old style" CMake, and is incompatible with KDE ECM and Frameworks, so using CMake 2.8 (as allowed by the top-level CMakeLists) will almost always fail later. You need at least 3.0 for KDE Frameworks. I'd recommend 3.16, released at the beginning of 2020, since recent KDE Frameworks work best with that version and later.
• KDE ECM 1.0 ; this is the 2014 release, which was before ECM modules like ECMAddAppIcon were added, so using ECM 1.0 will fail to include that module. I'd recommend something like 5.18, which is still terribly old, but supports Debian 10 (which is nearly end-of-life) still.
• Qt 5.5 ; this has been end-of-lifed so long ago I'm not going to look it up. 5.12 is still available on Debian 8 (Jessie), which is past its end-of-life. The only supported Qt versions in any current Linux distributions are the 5.15 series. Only the KDE Qt snapshot, which I think is 5.15.5 now, has supported open-source releases. I'd recommend bumping this to 5.15.0.
• KDE Frameworks 5.37 ; that's very old, but might be useful. You should match your ECM and Frameworks versions, though, for consistency.

Note that "you need CMake 3.0 for Frameworks" isn't entirely correct: ECM 1.0 still supported CMake 2.8. Heck, even 5.37 did, it turns out. ECM didn't require CMake 3 (3.5) until 2019, around 5.56.