haidra-org / horde-sdk Goto Github PK

From what I'm understanding on how CivitAI's API response is, lora.id is a number (which should be casted to a string when sending to the Horde), while ti.id is a string.

TLDR; GlowingRunesAIV6 is a TI and should be moved under the TI array.

I'm considering opening a PR myself, but my Python foo isn't super solid.

It looks like it's mentioned in a number of places here:
https://github.com/search?q=org%3AHaidra-Org%20GlowingRunesAIV6&type=code

As of Haidra-Org/AI-Horde@5c5d3dd, there should be enough information in the swagger to dynamically valid error responses. write_all_response_examples_to_file in swagger.py already has a bool keyword argument error_responses which will write out all of the published error responses to json for pytest/CI.

Some thoughts:

• The API is missing some possible HTTP return codes for errors (this is often because nested function calls can make it difficult to determine which exceptions might be raised and changes to shared functions make it hard to identify which endpoints to decorate with the possible new return codes).
• As of today, all of the example errors are identical. It may or may not serve us to include examples which vary from endpoint to endpoint (or at least, vary at all).

TI embedding support, especially once many (dozens+) are available may require some sort of conflict resolution to make sure trigger terms are not overriding each other or being confused.

• extra_source_images

See Haidra-Org/hordelib#219.

• todo -

• Haidra-Org/AI-Horde-Worker#268
• Haidra-Org/AI-Horde-Worker#249
• Haidra-Org/AI-Horde-Worker#237
• Haidra-Org/AI-Horde-Worker#227
• Haidra-Org/AI-Horde-Worker#226
• Haidra-Org/AI-Horde-Worker#219
• Haidra-Org/AI-Horde-Worker#202
• Haidra-Org/AI-Horde-Worker#199
• Haidra-Org/AI-Horde-Worker#193
• Haidra-Org/AI-Horde-Worker#182
• Haidra-Org/AI-Horde-Worker#63
• Haidra-Org/AI-Horde-Worker#60
• Haidra-Org/AI-Horde-Worker#59
• Haidra-Org/AI-Horde-Worker#14