hacknocraft / appfriendsui Goto Github PK

In the following scenario, users are unable to leave a conversation:

1. Tapping the "Leave conversation" on the first dialog (either by swiping right on the dialog list or from the Settings screen)
2. Hitting the iOS Home button
3. Re-opening the app

After step 1, the dialog disappears but in step 3, the dialog re-appears and in a broken state (unable to send messages - the users get failed message indication, dialog is not named, etc.).

Steps to reproduce:

1. Device A is logged in, with the app running in the background.
2. Device B creates a brand new direct message with the user on Device A.
3. Device B sends a message.
4. Device A gets a push notification from GC (you can be in the lock screen or home screen, as long as the app isn't open)
5. Device A's user taps the push notification. The message opens, there is content in the chat view however the title is showing "unknown" instead of the user's name.

Note: if user A navigates back to the convo list and then back to the DM, the title is showing user B's name as expected.

1. Adding Photos & Video: Tapping on the media icon (on the left of the Enter Message field) should bring up an action sheet as it did before. Currently changes keyboard to show 2 icons for taking a picture and accessing photo library

2. The media icon should be a camera icon rather than a plus icon

The New Messages line doesn't appear if the user has more than 20 unread messages.
The New Messages line should appear, as the name suggests, even when there are more than 20 new messages so that users know what they've missed on and have context.

See screenshot. Expected behavior: The popover should point to the "share" icon in the upper-right, not appear in the upper-left.

Using AppFriendsCore 2.1.0, AppFriendsUI 2.2.0

When sending a message to a large group (over 242 users), I'm noticing that the message first appears to be in a failed state (red exclamation mark icon). Only after a few seconds, the failed mark is cleared and the Seen By screen is available.
This creates a UX and performance issues with users since they think the message wasn't sent and will continue sending more and more.

I think you might need to change the timeout period for when you display the failed message icon.

Enable a user to share his current location or a custom location to a chat dialog

Sometimes, a message cannot be sent.

In this case, a user was trying to send a message and kept getting an error.
After quitting the app and relaunching, he was able to send a new message although the original failed message would not send. See attached video.
failedmessage.mov.zip

Refactor public api so that the developers have easier time and consistent experience using the SDK.

The problem with the 1-1 conversations seems to be that if the user who leaves the message sends the last message, the dialog comes back to the list and is titled as "Private Conversation"; it seems that the last message the leaving user sent is appearing as an unread message, so the api call is pulling the conversation back down to the user who left's device.

Note that this also happens in Android (https://github.com/Hacknocraft/AppFriendsAndroidCore/issues/38)

Links are no longer clickable and users are forced to copy and paste the link into a browser.

The ideal behavior is that a user taps on the link will get two options:

1. Open
2. View the Read Receipt

The current icon used for involing the action sheet while viewing a picture is an Android icon rather than an iOS one.

After picking from album, share a full screen preview before sharing happens.

Not having to tap on the side of the message to check receipts anymore in the provided UI

• Link text colors should be different depending on whether the link was send by self or another. Links within messages from another member should be #0080D6 (blue). Links within messages the user has sent should match the non-hyperlinked text (white). Ref Image: https://www.dropbox.com/s/d0q7s1bwrnnvamm/WH-32.png?dl=0

• The join message is missing spaces after commas between names, within the content area

• Send button behavior & style is inconsistent with spec. Behavior should be persistent and just be enabled / disabled based on whether there’s text in the field. Remove the paper airplane icon. Send Button should be #0080D6 in color when enabled. Send Button should be #C8C8C8 in color when disabled. Ref Image: https://www.dropbox.com/s/ef9277s4viec3m8/WH-10.png?dl=0

• Use the asset in the spec for the Forward (>) icon. Ref Image: https://www.dropbox.com/s/rccm6xk89a822vy/WH-20.png?dl=0

• When opening a view with a lot of messages, from Push, the blue New Message line indicator is aligned to the middle of the page, not the top under the Navigation Bar

• the Left/Right padding of the message content is off. Padding on all elements that are aligned on the left side should be 16px from the left screen edge. Padding on all elements that are aligned on the right side should be 16px from the right screen edge. Ref Image: https://www.dropbox.com/s/in5srdogxztq8bd/WH-03.png?dl=0

• The padding between clusters of messages from the same sender is too big. Should be 4px padding between message clusters from the same sender. Ref Image: https://www.dropbox.com/s/gr5fnjb87ctgeeo/WH-04.png?dl=0

• Spacing between different senders is inconsistent. Should be 24px padding between messages from different senders. Ref Image: https://www.dropbox.com/s/e8tbspxjkavmcu7/WH-05.png?dl=0

• User join & group rename text has padding above & below that is inconsistent & too large. Should be 24px padding above & below user join & group rename text. Ref Image: https://www.dropbox.com/s/0z5sz967wjzj4nl/WH-09.png?dl=0

• Error state not consistent with Spec. Ref Image: https://www.dropbox.com/s/9av8zrqz9q050qb/WH-33.png?dl=0

• New Messages indicator font style should be SF UI font, 13pt size, Semibold weight. Ref Image: https://www.dropbox.com/s/koul97myt6afkos/WH-34.png?dl=0

• General stream timestamp (within the message stream) text style is inconsistent. Text weight of the day part (Oct 23 / Monday / Yesterday / Today) should be Bold. Text color should be #A6B4BF. Remove the comma after the date, because date will already be bolded to visually separate it. https://www.dropbox.com/s/fmre9rp3pwdh8tg/WH-12.png?dl=0

• Spacing under message sent by self is smaller than spacing under message sent by others. Possible to match them? Ref Image: https://www.dropbox.com/s/e4wjatdzd6z9rj5/WH-41.png?dl=0

When a user logs into another device, we should try to make the badge as accurate as possible.

The typing indication is inaccurate: even when users are still typing, the "x is typing" indication disappears a few seconds after the typing has begun.

• Text field to name this group isn't really a text field. It should be a text field that the user can type in directly, and saves when the user exits the settings. Currently, tapping the text field gives the user a modal with a text field in it. The grey suggestion text should just be "Name this group" instead of the name of the group. Remove the pencil icon on the right. Zeplink: https://zpl.io/ZEtwFB

• Fix line weight in "Leave Message" cell / footer. The line style needs to be 0.5px, #A6B4BF. Ref Image:https://www.dropbox.com/s/3g8ysmvl6i9ruqp/WH-14.png?dl=0

• Copy Change: 'Members' (2nd list item) should say 'Group Members'

• Copy Change: 'Mute Conversation' (3rd list item) should say 'Mute Push Notifications'

• Copy Change: 'Leave Conversation' (red outline button) should say 'Leave Message'

Replace the image share icon to be more iOS-like instead of using the google icon

Currently it seems that Socket.IO fails to build but there might be other issues.
It would be great if you can update on the ETA for supporting Swift 3.1.

Thanks.

All messages history is cleared when a user logs out. When logging back in, the dialogs are available but the content is empty.
As discussed, we should display the last 100 messages per dialog when logging back in, including media.

If a user is on their lock screen > then added to a group conversation > then receives a push notification for having been added > the user cannot send a message to the group until they close and reopen the convo

Steps to Recreate:

User A on Device X
User B on Device Y

1. Log into the app with B on Y, then go to the lock screen
2. From A on X, create a group convo and include user B
3. From B on Y, open the push notification for the user being added to that group
4. From B on Y, try to send a message in that group convo

Notice that the user will not be able to send the message as the app will display the error icon next to the message until the user closes the conversation and reopens it.

Expected Behavior: The user can send a message immediately after opening that initial push notification that alerts them they were added to a new group conversation.

The media bubble should be tappable to access Media View.
Media View will have an explicit ‘Seen By’ button within it, as seen below.

Abhinav, Ron, Aman, and I were chatting in our PM group when Abhinav sent two messages that were received by me and Aman, however they never made it to Ron's phone (messages before and after were delivered properly).

The screenshots below show that two messages sent from Abhinav ("nope", guessing you're testing address recognition?") are missing in the second screenshot.