When editing an existing H5P activity, the form forces user to re-upload the .h5p package.

it is great to have this plugin for moodle and h5p! I would like to know whether it support Moodle 3.0?

Many thanks!

In some locations the plugin is using $CFG->sessioncookiepath setting for URLs.

For example:

• https://github.com/h5p/h5p-moodle-plugin/blob/5ecda82164d94cc5e37d81628dcdbb7ee3960bf6/locallib.php#L38
• https://github.com/h5p/h5p-moodle-plugin/blob/5ecda82164d94cc5e37d81628dcdbb7ee3960bf6/locallib.php#L181

This is breaking loading of assets when Moodle is installed in a subdirectory. By default the values is / causing the URLs to miss the subdirectory:

• Expected:
  • www.example.com/subdirectory/pluginfile.php/123/mod_hvp
• Actual:
  • www.example.com/pluginfile.php/123/mod_hvp

Is there a reason why $CFG->sessioncookiepath is being used? Can it be replaced?

I got this error when uploading h5p content to moodle:

Fatal error: Class mod_hvp\framework contains 2 abstract methods and must therefore be declared abstract or implement the remaining methods (H5PFrameworkInterface::getLibraryStats, H5PFrameworkInterface::getNumAuthors) in /var/www/moodle/mod/hvp/classes/framework.php on line 983

So in order to avoid declaring the framework class abstract i've commented both H5PFrameworkInterface methods until they are implemented in the framework class

Now it works.

Just for you to know ....

BTW nice work on the plugin!

We must probably create a File interface and a default implementation in Core. The default impl. will work directly against the file system.
The Moodle plugin will require a custom impl. which uses Moodle's File API.

Checkboxes for the following options should appear in the form for H5P content:

• Display action bar and frame
• Download button
• Copyright button

The options should look and work just like the options for the WordPress plugin.

The goal of this issue is to make sure this Moodle plugin is simple to use and easy to understand.

It would be nice if we could control the visibility of YouTube video thumbnails while hovering the timeline progress bar, as it is abailable on YouTube.com original video player.

Maybe, it has to do with YouTube Video Player API param: showinfo?
https://developers.google.com/youtube/player_parameters#showinfo

The most ideal is to use the version number of the plugin.
Should be fixed in hvp_get_core_assets() in lib.php

Make sure completed events from the content is sent to the gradebook.

https://docs.moodle.org/dev/Gradebook_API

Some places in the framework interface there is code which is exactly the same for all implementations of it. E.g. in saveLibraryData() and saveLibraryUsage().
If we move this code to Core it will ease maintenance.

We must verify that H5P.getUserData() works when H5P Content is displayed. Must also work when data isn't preloaded, although I'm not sure if it used.
I think maybe Interactive Video uses it to check if the Tour has been taken.

See https://docs.moodle.org/dev/Gradebook_API#Gradebook_redirection_page

Makes it easier for other plugins to alter or modify the library semantics.
Implement alterLibrarySemantics() in hvp.php.

WordPress plugin's alterLibrarySemantics()

There must be options to configure saveFreq, perhaps through CFG?

contents_user_data action must be handled in ajax.php and the data stored.

Loading is done in #14.

H5P Content must be editable inside Moodle.

Must be done after #29. Cannot be tested before #47 is done.

Implement interface allowing for file upload support in the editor. There may be a need for adding functions to the moodle implementation of the h5p file storage interface.

Makes it easier for other plugins to alter or modify the scripts and styles that are loaded.
Should run after $core->getDependenciesFiles()

WordPress plugin's alter_assets()

Hi,

I install H5P plugin on a moodle 3.0 version, without problems, but when i create a new activity on a course, simply i can´t see anything...

Then i start inspect element on google chrome and see just the attached image

I install the same plugin on a same moodle version running in desktop mode to test and there everything works fine.

Any suggestion is welcome.

Thanks in advance!

Check that all the capabilities that are needed exist and that the permissions seems natural and work.
#22 must be fixed before this.

Like this: https://docs.moodle.org/dev/Activity_modules#install.xml

• Activity viewed
• Activity index viewed (when implemented)
• For Interactive Video: Video player events (Play, stop, seek, pause, interaction?, finished)
• Grade updated
• xAPI statement fired (maybe? instead or in parallel of sending it to an external LRS)

It's very common to Moodle modules to have an Intro form element that is displayed to the users at the top of the module's main page. In H5P's case, above the video. and it usually includes some instructions for students about the specific activity or resource.
(I am not sure, but it could be actually required to be implemented by Moodle HQ if it is going to be approved by them, and added to moodle.org/plugins database)

Please see if you can add one to the hvp module.

... and that H5P content is successfully restored.

Must be checked after #19.

Currently an entry will be added to the gradebook even if the H5P activity doesn't have any interactive content (questions that the user answers).

Is there a way for the H5P content to tell Moodle whether it contains questions that are usable for grading?

Make sure all files and functions are documented.
Remove all TODO: Document

This issues must be verified before release.

Hi, Since I added the plugin I can't run the cli/cron.php task anymore, is it a known issue and is there a solution please ? Thanks for the awesome work !

Should we make it possible to insert H5P Content into the Page resources?

Should be the same as the one for WordPress and Drupal.

Content Upgrade should be working.

There's something funny going on with the git submodule:

$ git status

    modified:   library (new commits, modified content)

$ git submodule update 

    fatal: reference is not a tree: e3aa6323f55acd635b8b0056f7ab92b76043f9d9
    Unable to checkout 'e3aa6323f55acd635b8b0056f7ab92b76043f9d9' in submodule
    path 'library'

Must be done after #29. Cannot be tested before #47 is done.

This involves copying moving and cleaning up files. See how this is implemented for Drupal and WordPress.

The version.php mentions Moodle 2.5.3 (11 November 2013) as the minimum requirement.

So far I haven't gotten the plugin to work neither on 2.8 nor 2.7, so apparently something has changed in a non-BC way between Moodle 2.5 and 2.7.

• Figure out what
• Figure out how much work it requires to make it work on newer versions

Makes it easier for other plugins to alter or modify the parameters before they are printed.
Should run after $core->filterParameters()

WordPress plugin's h5p_alter_filtered_parameters

contentUserData must be set in view.php.

ajax.php must handle loading of data.

Saving is done in #13 and should be implemented first.

Is there any plans (roadmap) on adding an xAPI dispatcher?
outside of Moodle, to an LRS?
or inside Moodle, (1) into a custom hvp DB table (2) Moodle's mdl_logstore_standard_log ?

In order to upgrade the plugin to use latest H5P PHP library and Moodle version, some of the database tables need to be altered.

Is the plugin currently being used somewhere? If not, there's no point in wasting effort to make an upgrade path. I'll just add the alterations straight to the installation feature.

In case the plugin is being used, would someone be able to duplicate it into a test environment and test the upgrade path?

Hi,
I installed the plugin with Moodle 2.8 and Oracle. When I imported my first content I got an error due the use of keyword LIMIT in "classes/framework.php" line 302. Oracle (and some other DBMS) doesn't support LIMIT
Maybe using $DB->get_records_sql($sql, array $params=null, $limitfrom=0, $limitnum=0) could work..

Removing the LIMIT condition the query works.
Thank you for the plugin!!!!

The h5p results will be stored in the moodle grades? As i am using H5P in drupal currently, the h5p results only record the result in last attempt, but Moodle support multiple attempts, so will all the results recorded?

Thanks!

Moodle provide a Repository API that enable any plugin to enjoy a pluggable framework of repositories that can prove easy search and retrieval of video URLs from various sources (web and local repositories). It is the standard way for content creators (and students) to input video URLs.
It could be very useful to integrate it with the "Upload/embed video(s)" Tab in the Interactive video content editor.

You can see it in action when you add a URL resource to a course.
https://github.com/moodle/moodle/blob/master/lib/form/url.php#L122
https://github.com/moodle/moodle/blob/master/lib/form/url.js

As the plugin requires the module mod_assign, which is just available from moodle 3.1, it breaks older moodle instances on installation, at least for me.
So probably the required value in the version.php should be increased to 2016052300?

We (The RTL folks) missing an RTL/LTR button on the editor's toolbar, everywhere text can be edited.
Example:

(I am referring to Text flow, and not the Alignment)

Today, core uses the t() function of the framework interface with a default english translation.

We will have to change how the translation works in Core. We should probably use keys and then allow the implementation to create/use a map inside the t() function to fetch the correct translation. This will probably be the easiest way to deal with translations for most web systems.

Must be done after #29.

Make sure that the editor appears in the Moodle form for H5P, similar to the solution in Drupal and WordPress.

Should be fixed in the framework interface.

resetContentUserData() in hvp.php should reset data flagged with delete_on_content_change/invalidate when content is updated.

Also, make sure that data is removed when user or content is deleted.
#13 must be fixed first.