Code Monkey home page Code Monkey logo

h5p-course-presentation's People

Contributors

adpking avatar andreascerpus avatar dependabot[bot] avatar devland avatar e-me avatar falcon-git avatar fanncw avatar fnoks avatar germanvaleroelizondo avatar gwenillia avatar icc avatar j0kerz avatar jarvil avatar kagoya avatar kish5p avatar languafe avatar larsmagu avatar makmentins avatar maxtetdev avatar nmillin avatar otacke avatar sdif-diba avatar sokunthearithmakara avatar tajakobsen avatar thomasmars avatar timothyylim avatar translate-h5p avatar vildestabell avatar weblate avatar zouhairloucif avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

h5p-course-presentation's Issues

Translation in bottom toolbar

The Norwegian translation tooltips for the following buttons need to be changed:

"Flytt slide right" is a mixture of English and Norwegian and should be changed to "Move slide right" or "Flytt slide til høyre" Similarly, change "Flytt slide left" to "Move slide left" or "Flytt slide til venstre".

H5P doesn't display at all after updating

Hello,

after updating mod_hvp to 1.19.1 H5P-acitivities dissappear at random so when you open H5P-acitivity it's blank (browser doesn't matter happens on chrome and IE11) , sometimes they show and sometimes they don't. Only error is this from console

Uncaught TypeError: Cannot read property 'find' of undefined
    at S.setOverflowTabIndex (2209b9043998524046930798eb31a6e448cf220b.js:3775)
    at S.attachElement (2209b9043998524046930798eb31a6e448cf220b.js:3775)
    at i.t.appendElements (2209b9043998524046930798eb31a6e448cf220b.js:3775)
    at S.createSlides (2209b9043998524046930798eb31a6e448cf220b.js:3775)
    at S.attach (2209b9043998524046930798eb31a6e448cf220b.js:3775)
    at Object.H5P.newRunnable (h5p.js?ver=2019081600:944)
    at HTMLDivElement.<anonymous> (h5p.js?ver=2019081600:137)
    at Function.each (jquery.js?ver=2019081600:2)
    at init.each (jquery.js?ver=2019081600:2)
    at Object.H5P.init (h5p.js?ver=2019081600:93)
first.js:39165 Init add block button adder
DevTools failed to parse SourceMap: https://moodle/lib/requirejs.php/1566796628/core/popper.js.map

@thomasmars @icc

Urgent issue: cannot edit embedded interactive video in Moodle at all

Hello,

You cannot edit interactive video embedded in Course presentation at all. Clicking the pen icon doesn't do anything. This happens in Moodle, in h5p.org this doesn't happen.

Tested with Moodle 3.3 & Clean/Boost themse & mod_hvp 1.5 and 1.6 & Course Presentation (1.17.8) & Interactive Video (1.17.5)

Steps to repeat;

  1. Create course presentation
  2. Add interactive vide on the first page
  3. Save and return to course
  4. Open the H5P in editing mode and notice how you can't click "edit" button.

h5p

Mix og English and Norwegian in dialogue boxes

IN some dialogue boxes in content type settings there are mixture of English and Norwegian, and also some typing errors. One example:

In the Dialogue Card content type, when opening Innstillinger for oppgave-oppførsel, three of the settings are in Norwegian and one in English. Moreover, there is a typing error in setting no. 3: "Skaler teksten til å få pplass i kortet" should be changed to "Skaler teksten for å få plass på kortet".

Why is printing not possible?

I have tried to print a course presentation slide with a browser but I shows an empty (white) page. No text, no image is displayed. Other content types work perfectly.

Any idea what's the problem?

H5P Image Link

Would like to be able to create a link directly from an image rather than text.

In course presentations, only text can be hyperlinked. Would like to be able to create a link using just an image.

Multiple Single choice set -questions cannot be selected in Moodle

Hello,

  1. Create H5P course presentation
  2. Add single blank choice set question, click it to confirm that you can select it
  3. Add second blank single choise set and notice how you can't select it at all.
  4. Select save and display
  5. Edit H5P again
  6. Notice that you can now select the second "single choice set" but if you a add third one you cannot select it at all before saving/editing again.

This happens in Moodle with Boost-theme, if you use Clean-theme all of the created "single choice set" -questions are stacked and you cannot select them at all before saving and editing again.

Tested with Moodle Moodle 3.3.1+ (Build: 20170810) and mod_hvp 1.5 & Single Choice Set (1.9.6) & Course Presentation Editor (1.17.4) & Boost/Clean themes.

Feature request: Accordions

Would greatly enjoy seeing this new interaction added to the Course Presentation. (Or more broadly, documentation on how to add others.) Thanks!

Course presentation hidden in Moodle

Hi,
I've created a course presentation in Moodle but when I test it as a student it's hidden. There is no restrictions on access and I've also selected 'show on course page' in the settings. Any ideas please? Thanks.

Keyword-list, long translations are cut out

Hello,

If you translate keywordlist items and the translation is longer than the original english word, the "background" doesn't expand to cover the longer translation.

Tested with Moodle 3.5

coursepres

Pull Request: CoursePresentation Social Media Sharing

CoursePresentation Social Sharing

As I'm sure you're aware, social media sharing upon completion of a CoursePresentation currently only has the option for sharing with Twitter. I have modified the library to support Facebook, Google+ and added a couple more options for Twitter following the standard set by the SummarySlide prototype: addTwitterScoreLinkTo().

Settings

The administrator is able to modify what is shared by default using the Behaviour settings menu whilst in the Course Presentation editor.

Twitter

Option Description
Share to Twitter statement The text to fill the Twitter share textarea with.
Share to Twitter link A link to place after the share statement, before the hashtags
Share to Twitter hashtags A comma-separated list of hashtags to place at the end of the textarea.

Facebook

Option Description
Share to Facebook Link A link to a relevant landing page for the public
Share to Facebook Title The title to place on the link in the post
Share to Facebook Description The text to place in the shared link area as a description
Share to Facebook Quote Text to place into a styled Facebook quote

Google+

Option Description
Share to Google Link The link to direct the public to when shared

Placeholders (To be used in the above settings)

Placeholder Description
@percentage The score percentage earned during the CoursePresentation
@url The url of the current page the H5P is on

Issues

Facebook App Id

A Facebook App Id has been discussed before and has more to think about than merely creating a shell Facebook Application to allow everyone to implement with. Rate limits from Facebook seem to be fairly forgiving, although this does not mean future planning should not take place; given that this is a public utility and may be hosted from multiple locations, I would suggest creating an ID on a per-library basis, especially in the event that Facebook change their rate limits.

Context Privacy

Obviously for paid or closed platforms, sharing a direct link to the H5P can be an issue and prevent people from using the @url placeholder. You can, however, provide a URL to a location other than the specific course,lesson or resource the H5P is located in, allowing users to be pointed towards a useful or resourceful place to learn more about the service. This may be, for example, a shop front in which you can buy the resource somebody else shared their H5P progress for.

Course presentation comment-field alignment problems with Internet Explorer 11

Hello,

There is a bug in Course presentation comment-field alignment with Internet Explorer 11. See attached video.

This appears only when you have first created f.ex. multiplechoice question in course presentation -> saved the question -> and when you go to edit it again.

When you are back editing and add text to the comment-field -> select it -> click the link icon -> the pop up opens to the right part of the screen and you cannot even see/use it. This with Moodles Clean theme.

If you now, with this pop-up open, scroll browser vertical scrollbar to the top of the page you can now see the editor since it moves to the top left of the h5p editor. If you then move it back down it goes to the right and is non editable.

tested with Moodle 3.5.3, mod_hvp 1.12, moodle theme Clean.

Steps to repeat:

Create course presentation
add multiple choice question -> choose done
now edit the multiple choice question with Internet Explorer 11
Go comment-field -> type something -> choose text -> click link icon -> notice how the alignment is wrong

Problem with Clean theme:
comment.zip

Feature suggestion: Draw simple shapes

It would be so amazing to draw or insert simple shapes: circle, rectangle, line/arrow over slides. To be able to highlight important information on the slide....

I will be experimenting locally, trying to make something work with integrating JS libraries for shape drawing. If it will be good enough will try to do my first pull request.

Would love any help or advices.... =)

Change styles of yours packages

Hi,
First of all, thank you for that incredible framework.

My question is, can I change, for example, the css of one of your components( like course presentation) and upload to drupal to use with my changes and create new content?

How to translate toolbar buttons?

Hello,

I want to translate (to Finnish) all button hovers in course presentation toolbar but I don't know where to translate them to?

f.ex button called image. The text image doesn't exist in;

https://github.com/h5p/h5p-editor-course-presentation/blob/master/language/fi.json
or in
https://github.com/h5p/h5p-course-presentation/blob/master/language/fi.json

and it's already translated to h5p image -libary (which it could come from):
https://github.com/h5p/h5p-image/blob/master/language/fi.json

hover

xAPI Completion Problem

If you create a course presentation and disable the "summary slide," there is no xAPI "complete" statement generated when a user reaches the end of the presentation.

Catalan Translation

Hi there,
First of all, Thanks to the great job you've been doing to develope this powerful tool. I'd like to submit you a Catalan translation for this module.

ca.json.zip

Best regards
Aitor

Scroll bars do not appear on AdvancedText objects

cp.css contains the following:

.h5p-course-presentation .h5p-element .h5p-element-inner:not(.h5p-interactive-video) {
  overflow: hidden;
  overflow-y: auto;
  background: transparent;
}

...which suggests that the intention is for a scrollbar to appear when there is, for example, more text in an AdvancedText than will fit (which I definitely need for some modules). However, for reasons that aren't entirely clear to me, at least in Chrome, this doesn't actually happen unless the element also has height: 100%;.

Setting this doesn't actually affect the size of the element, since "100%" just means to fill the .h5p-element-outer container, which is looks like it would normally do anyway? I haven't seen any instances of having more than one inner element in an outer, at least.

Assuming that's true, it looks changing the stylesheet to the following would cause scrollbars to appear as expected without breaking anything else:

.h5p-course-presentation .h5p-element .h5p-element-inner:not(.h5p-interactive-video) {
  height: 100%;
  overflow: hidden;
  overflow-y: auto;
  background: transparent;
}

Does that sound reasonable?

IOS 13 Support for go-to-slide brocken!

Starting with IOS 13 and IPADOS 13, h5p-element-inner h5p-go-to-slide links no longer work.

The problem occurs with all IOS & IPADOS browsers (based on Webkit).
For example see: https://h5p.org/presentation
(1st slide bottom right)

Is a workaround or bugfix known?

Best regards
Sven Zimmermann

Feature Suggestion: "Force Correct Answer" to progress

I want to prequalify a pull request related to the following:

User story:

As a content creator I would like to be able to limit users from progressing in a course presentation until they get the question correct. (Currently users can skip to the very end and skip questions)

This would mean the user can no longer navigate to any slide and must take the slides sequentially.

Retry would be mandatory when "Force Correct Answer" is enabled.

This is a very typical training feature that ensures questions get answered correctly to certify the user understood the content.

UX:
There would be a new checkbox in the "Behaviour Settings" of the course presentation

Accessibility:
Not relevant

Technical solution:
I plan to add a new setting just like "Hide Summary Slide" that is called "Force Correct Answers" with a description "This option remove navigation controls and forces users to take slides sequentially and must get all questions correct before being allowed progress"

xAPI Completion in Drag Text

There is no Completion info in the xAPI JSON sent out from the drag text activity type.

After the result object, other activity types have
"completion": true,
"success": false,
"duration": "PT1085.52S",
"response": ""

Is there another way to check that the "check" button has been pushed for the drag text activity?

Usability issue editing interactive video

When editing an interactive video as part of a course presentation (place on a slide) clicking on Done does result in saving the changes for the interactive video but the Editor screen persists and does not go away (internet explorer 11). When the whole Course presentation is saved all changes have been made. This is a major usability issue in Course Presentation. Other content types can be saved and the editor screen disappears and work can be continued without Saving the whole presentation first.

full screen option visible when IV is embedded in course presentation

when is interactive video is added to a course presentation, in some cases the full screen option appears 2 times, in the video and for the course presentation. and in other cases in the same course presentation is the full screen option for the interactive video does not appear, which is the desired option.

Image Hotspots not part of Course Presentation

Similar to https://github.com/h5p/h5p-course-presentation/issues/22, even Image Hotspots library cannot be used in a Course Presentation.
I've submitted pull requests for the same. See #24, h5p/h5p-editor-course-presentation#4.

While my pull request does make Image Hotspots usable in Course Presentation, it also distorts the pop-up UI and doesn't position itself relative to the hotspot.

I am not a jQuery/CSS expert, so if there is anybody who can fix it..nothing like it.

Thanks in advance.

Regards,
Supriya Rajgopal

No result for simple Course Presentation

I'm using the WordPress plugin and I have created a 3 slide ‘Course Presentation’ with no quiz in them.

It seams that it will not send a finish statement when all slides are viewed.

I would expect a h5p_setFinished action to be sent, but I only get h5p_contents_user_data. I have installed “H5PxAPIkatchu” plugin to check for xapi calls. There are no ‘completed’ verbs registered for this simple course with no quiz. No summary page also.

test-22.zip - This is my course. It can't get more basic than this.

Not sure what to do in order to track completion of these courses.

Switch to a given slide from within an embedded iframe

I posted my question already in the forums, but it probably better fits here:

I am currently evaluating if a Course Presentation could be used for a simple point and click adventure (with Active Surface enabled). To give me more flexibility I successfully added an iframe to a slide and loaded a small minigame. Now I am struggling to switch to a different slide from within the iframe's minigame to continue the game at a different point. I tried to call jumpToSlide() from my minigame, but it isn't working because of lots of undefined values:

parent.window.H5P.CoursePresentation.prototype.jumpToSlide();

So any idea how I can use jumpToSlide() to switch to a given slide?

Question Set not part of Course Presentation

Course Presentation is indeed very powerful but it lacks inclusion of Question Set content type.
I have modified the Course Presentation 1.10 & added a minor condition in H5P.QuestionSet1.8\js\questionset.js to make this feature available.

Modified files:

  • H5P.QuestionSet-1.8\js\questionset.js
  • H5P.CoursePresentation-1.10\semantics.json
  • H5PEditor.CoursePresentation-1.10\library.json

Please find attached the above 3 libraries.
QuestionSet_CoursePresentation.zip

Localization esthetics

Slide can be localized into some like Page, but it Always displays as this

Slide1, Page1. It is not possible to add a space like this:

Slide 1, Page 1

Data reset message everytime after editing?

Hello,

I'm using Course Presentation Editor (1.16.0) & mod_hvp 1.4 (2017060600) & Moodle 3.3.1+ (Build: 20170727).

When I edit course presentation and add an image to it and press "save and display" I get an error message. Once this has happened it happens everytime I enter edit mode and "save changed and display" even if I don't change anything. The error message is;

"Data reset"

"This content has changed since you last used it.

You'll be starting over."

dataresett

and there is a OK button. What does this mean? It seems that the changes are saved anyway.

two or more audios

If a slide has two audios set to play automatically, they both play at the same time. It would be nice if I could have one play after the other is finished.

Scroll when you check question

When pressing "check" at a question the content gets to big for the frame and the users have to scroll in order to see the feedback. Some of the users does not realize they have to scroll and never sees the correct answer or feedback. Perhaps this could be fixed by resizing or something?

Hide slides for presentation

Is it possible or planned to allow to hide/disable a specific slide for presentation. The slide should be still included in the editor but just removed when showing the course presentation. Similar to the functionality in Powerpoint.

Copy/Paste doesn't work with MAC-computers

Hello,

You cannot Copy and paste images in course presentation with MAC computer + Safari/Chrome/Firefox, in Windows 10 you can;

  1. Select image
  2. Press CTRL+C
  3. Go to the slide you want and press CTRL+V to paste the image as many times as you want

This way you don't have to upload a same image every single time when you want to use it on several slides, you can just easily copy/paste it where its necessary.

Slide advances automatically after N seconds

It would be nice to have an option for the slide to advance automatically after N seconds. Then it could be used as an image slider for a website.

It would be nice to adjust each slide independently and also have a default time setting.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.