Code Monkey home page Code Monkey logo

lastfm-unscrobbler's People

Contributors

allie-wake-up avatar arthursiqueiras avatar cennoxx avatar guytepper avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

lastfm-unscrobbler's Issues

Show Progress indicator?

Is there possibly a way to show the deletion progress with a in-window pop-up rather than having no visual cue that the scrobbles are being deleted?

Error message when using the extension on Google Chrome

An error message like this pops up whenever the extension is clicked on, even while on the mentioned pages. Didn't happen a few days ago, so it seems to be new. Sometimes it works without any error, but that's typically only on the first page of the user scrobbles library
ERROR

Incorrect styles on track scrobble history page

In the track history page the checkboxes appears on the right side instead of the left, and the Delete selected scrobbles doesn't show in bold red like it does in the profile page

Track page styles:
Screen Shot 2022-07-16 at 9 08 53

Profile page styles:
Screen Shot 2022-07-16 at 14 09 11

Suggestion: modify this to work in library's track page

Hey,

so I noticed this doesn't work on the track page within library, even though it's possible to delete the scrobbles there per track. So this page: last.fm/user/username/library/music/artist/_/track.

Would it be possible to get the unscrobbler to work there as well?

selection disappears if timestamps change

Noticed in Chrome and Firefox:

  • if the delete icon is pressed the checkboxes are shown
  • if then the timestamps (right in the picture) change (for example from "3 minutes ago" to "4 minutes ago" โ€ฆ) the checkboxes disappear (the "Select All" button is still there)
  • the checkboxes can not be shown again, only if the page is reloaded

That's especially frustrating if a selection is already made and it then disappears.

grafik

not currently working?

Hi! Is this currently working? I'm running Chrome Version 92.0.4515.159 on MacOS Mojave. The extension activates, the checkboxes and menu item appear, but nothing happens when I click on delete. In the javascript console I see:

unscrobbler.js:150 Uncaught TypeError: Cannot read property 'click' of null
    at unscrobbler.js:150
    at Array.forEach (<anonymous>)
    at HTMLButtonElement.deleteScrobbles (unscrobbler.js:147)

What else? Anything I can do to troubleshoot?

Can't set extension to auto-enable on Chrome settings

I can enable or disable "Allow this extension to read and change all your data on websites you visit", but it doesn't change anything, in both cases the only option is to activate the extension by clicking it, it doesn't let me set it to be activated only on Last.fm automatically or on all sites. I tried both downloading the extension from Chrome Web Store and running it by downloading the source code, the same thing happens in both scenarios.
image
image

Add "Select All" button

Add a button that will allow selecting all checkboxes in the current page.

Some behaviour caveats:

  • On the profile page, only the recent tracks should be selected (instead of all tracks on the page).
  • When pressing the button again, all tracks should be deselected.

How to approach:

  1. Create a new button element and insert it to the page. You can see an example here.
  2. You'll probably need to adjust some of the styles Last.fm uses in order to make it positioned correctly.
  3. Attach an onclick event listener, that when fires runs through all the checkboxes and checks them (and then change it so the button will deselect them).

All of that should take place in the unscrobbler.js file.

Styling & Position:
For styling, let's use the btn-secondary and btn-sm classes that Last.fm use to style small buttons.
It looks like that:
screen shot 2018-10-02 at 11 13 12

The button should be placed on top of the page:
image

Extension doesn't work correctly in Firefox

The extension only works when you click the extension icon - however this doesn't appear in Firefox.

The icon doesn't appear in the toolbar by default and also can't be added via the Customize Toolbar menu - it seems as if the extension has no toolbar icon/behaviour.

I'm using Firefox 101.0 on Windows and Mac and the same issue occurs on both.

Not the biggest deal as I can swap back to Chrome when needed but some users could be confused :)

Improve checkbox range selection mechanism

Checkbox range selection has been added in #8. It works well when selecting a range of checkboxes for the first time, but when trying to add more checkboxes, it doesn't work as expected:

2019-09-28 02 26 54

The desired selection mechanism should be something like this (example taken from checkboxes.js, Enabling range selection of checkboxes section):
2019-09-28 02 45 25

Doesn't works on Chrome and Firefox

Hi,
I tried today to use the extension on Chrome and it doesn't works anymore ? I don't have any tickboxes even when I click on the extension, nothing happens.

And on Firefox, it says the extension can't read nor modify the data (the message is in french because I'm french so I tried to translate it in English) and the extension is grey, can't use it. Thanks

range selection doesn't work

Noticed in Chrome and Firefox:
The range selection doesn't work. I open a new page at last.fm, click the addon icon, use shift+click to select two checkboxes, but only the ones I click are selected, not the range between them.

Firefox and Chrome different scrobble select behavior

On Chrome you can click anywhere within the scrobble (the area marked on red) to check the small tickbox, but on Firefox you have to click directly on the very small box to select the song. This makes selecting multiple scrobbles very tedious compared to the Chrome behaviour. Is it possible to implement this on Firefox the same way it works on Chrome?

image

closed

sorry i mixed it up with a different extension so i thought it was not working properly

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.