guillermomuntaner / gmimagepicker Goto Github PK

Hi,
first of all thank you very much for making GMImagePicker, I really like it. But I'm having a problem with collections: they are either empty, or show only a little bit of what they contain, possibly in a very weird layout. I suspect that it may have to do with what images are available on my device and what images are not. I made a little video that shows it in detail here: https://www.dropbox.com/s/j9vj7k39wiogejk/GMImagePickerCollections.mov?dl=0

Any suggestions to what I should be looking at? I'd be happy to go patch it and contribute the fix back, but at the moment I'm just confused. ;-)

The app running in the video is the example as downloaded today (2016-04-05) running on my iPhone

Cheers

Nik

The appropriate language isn't populating into the various labels. Instead, it just shows the keys for each label. (Installed using CocoaPods 0.36.0)

Edit: This only occurs when the Podfile declares: use_frameworks!

When i select more than 50 photos application going to be crash and it provide this error.
=>Received memory warning.
=>code

• (void)assetsPickerController:(GMImagePickerController *)pickerdidFinishPickingAssets:(NSArray *)assetArray{

  self.requestOptions = [[PHImageRequestOptions alloc] init];
  self.requestOptions.resizeMode = PHImageRequestOptionsResizeModeExact;
  self.requestOptions.deliveryMode = PHImageRequestOptionsDeliveryModeHighQualityFormat;

  // this one is key
  self.requestOptions.synchronous = true;

  // self.assets = [NSMutableArray arrayWithArray:assets];
  PHImageManager *manager = [PHImageManager defaultManager];
  Albumimages = [NSMutableArray arrayWithCapacity:[assetArray count]];

  // assets contains PHAsset objects.
  __block UIImage *ima;

  for (PHAsset *asset in assetArray) {
  // Do something with the asset

  [manager requestImageForAsset:asset
                     targetSize:PHImageManagerMaximumSize
                    contentMode:PHImageContentModeDefault
                        options:self.requestOptions
                  resultHandler:^void(UIImage *image, NSDictionary *info) {
                      ima = image;
  
                      [Albumimages addObject:ima];
  
                  }];
  

  }

NSLog(@"%@",Albumimages);

[self dismissViewControllerAnimated:YES completion:nil];
}

Your lib is showing the total number of item in each album. Now i want to customize them to number of photo and number of video ? Is it doable? Please give me some advice. Thanks in advance.

It uses https://github.com/gmoledina/GMGridView which has crashes but is no longer being maintained as iOS introduced UICollectionView. So either this library should be updated or deprecated so people don't get stuck using code that isn't being maintained.

Hello,

I need to ask permission before open GMPicker.

If i denied permission then app crash.

thanks in advance.

Some testing in iPad 3 shows performance problems, probably caused because it is the first iPad with retina screen (high resolution images for low hardware).

I expected the disclosure indicator to be all the way to the right as opposed to partially to the left, as shown below:

Strangely, it seems to work fine on the iPhone in all orientations.

This occurs with Xcode 7.0 and iOS 9 (both simulator and device).

It seems that in didFinishedPickingAssets there is something going wrong. I dismiss the view and then show a text message to the UI. The first time ever that i install the app i cannot do any UI updates after the user launched picker . After that every other time the same code works.

http://prntscr.com/dd55od

When scrolling content in the album list or the photos grid, the content is clearly visible scrolling behind the status bar, but the navigation bar is opaque and so it looks terrible.

Please provide a way to extend the navigation bar behind the status bar
or allow setting _navigationController.navigationBar.translucent = NO

Hey, I'm having a lot of trouble with this crashing for some users on IOS10.
Below is my code which checks the permissions before loading the picker but users are saying that the app is crashing after selecting a few videos or just after loading the picker. I can't replicate on my machine but wonder if this is related to the changes in UIImageCollection made recently?

Please give me any ideas! I really need to get this fixed ASAP.

`- (IBAction)selectPhotos:(id)sender {

PHAuthorizationStatus status = [PHPhotoLibrary authorizationStatus];//checks if authorized to access

if (status == PHAuthorizationStatusAuthorized) {//is authorised to access
    GMImagePickerController *picker = [[GMImagePickerController alloc] init];
    picker.delegate = self;
    
    picker.title = @"Upload";
    picker.customNavigationBarPrompt = @"Select photos and videos to upload";
    picker.minimumInteritemSpacing = 1.0;
    
    [self presentViewController:picker animated:YES completion:nil];
}

else if (status != PHAuthorizationStatusAuthorized) {// if not authorised
    UIAlertView *alert = [[UIAlertView alloc] initWithTitle:@"Access denied" message:@"You've previously denied access to your photos so please go to settings and allow access." delegate:self cancelButtonTitle:@"Cancel" otherButtonTitles:@"Change settings", nil];
    [alert show];
}

}`

Does this library supports swift 3?

Is it possible to update the podspec accordingly?

Something to the effect of:

picker.photosOnly = true //Default false

top line where carrier and battery status is shown - is clear or gray. how do i change it to be the same as a navigation bar color, and also reduce the size of current navigation bar?

Hi,

Using photo kit sdk,i deleted photos from album but i can't delete them permanently as i see them getting stored in recently deleted album and the memory is not freed up.How can we delete photos from recently deleted album?
Any help is appreciated?
Thanks in advance...

Add a customisable navigation bar prompt (similar to photos app).

When you navigate to the Grid view for a different collection than the Camera Roll and you take a new picture while AutoSelectCameraImages is YES, the new picture is not automatically selected.

I added some code to the GMAlbumsViewController in my port to make sure the photo is auto selected even if not in view. See roycornelissen/GMImagePicker.Xamarin@708d035

I am on this. Will issue a PR soon.

I've had to implement a more native approach to the iOS grid view in my app where the GMGridView starts at the bottom and has the most recently taken pictures/videos there. I propose that something like this be implemented in GMImagePicker as it is how the native iOS photos app presents its content.

Would this be something you're interested in implementing? If so would you want it to be the default behavior or should there be an option to present the GMGridView both ways?

Hi..
I'm just add GMImagePicker in my test project, and launch GMImagePicker -> AlbumView(select Videos) -> video GridView -> back -> back.
But, memory doesn't released
Before launching GMImagePicker, memory usage 3.2M ,
after launching GMImagePicker and dismiss it, memory usage 7.1 ~ 7.5M
(My env : iPhone5 IOS9.0.2 , Xcode7.0.1 , Swift 2.0)
Please check it.. thank you

There seems to be an issue with the localised strings not loading, instead i'm seeing the ID's for the strings

Hello,

If i selected 5 photos from gallery and done. and we need to select those photo previous again by default selected.

Is it possible.

Thanks in advance.

See title...

I dont believe this is built in. It would be useful. If single is selected. When you choose one image it auto selects that. If you want a standard UI then you should do this.

up

Don't know the actual cause of this. It was really strange and rare. And we could not even reproduce it. It occurred sometimes though. Images displayed in Grid View got zoomed a little.

Did you experience the same?

My query is we are trigger image gallery in my app go to stright image section page not like a intermediate page..

I just want to say that this project is super awesome.
Coding style and comments are all very clear. It even can be a great tutorial for learning Photokit.

With iOS8.1 apple reintroduces Camera Roll, so the "All photos" category is not required anymore, since once of the Smart Albums is the Camera Roll itself.

Note in 8.0.x camera roll is still missing, so the All photos is still required for those versions (what a mess Apple)

Hi,
The "My Photo Stream" collection does not show up.
If you add the flag as described in issue #35 it does not make any difference.
I think it only works if you set the type to PHAssetCollectionTypeAlbum rather than PHAssetCollectionTypeSmartAlbum

When selecting a video asset from the grid of images and videos, I push the navigation controller to another view controller for trimming purposes. After trimming I come back to this view controller by popping view controller. As a result, the images and the layout in the grid is messed up and too much zoomed in. Only the visible cells are affected. When scrolling down deep, they are okay.

The below screenshot is before doing anything:

Below is the scenario where coming back to the GMImagePickerController from another view controller by popping mechanism:

As you can see, the time stamp is off to the top and the images are too much zoomed. Please suggest a fix for this. I even tried clipsToBounds = YES, but not helping.

Thanks in advance.

Could not able see photos and Albums which are synched from my mac in the iphone.

Specific Details

GMImagePicker is crashing in the most recent version of iOS 10 beta version (beta 3). It is crashing on this line:

[(UIView*)[_navigationController.toolbar.subviews objectAtIndex:0] setAlpha:0.75f]; // URGH - I know!

https://github.com/guillermomuntaner/GMImagePicker/blob/master/GMImagePicker/GMImagePickerController.m#L89

with the error:

GMPhotoPicker[2127:611046] *** Terminating app due to uncaught exception 'NSRangeException', reason: '*** -[__NSArray0 objectAtIndex:]: index 0 beyond bounds for empty NSArray'

and indeed if you stop there you find that _navicationController.toolbar.subviews is indeed an empty array.

Xcode Build

Xcode 8 Beta 2

iOS

10.0 Beta 3 (14A5309d)

when am selecting image you are showning the "1 photo selected" or some thing in the toolbartitle

so what i want is we have to show the selected image and make them add

is this possible with this sdk

Thanks for the Good sample

Picker is loaded empty and crashes during 1st launch when the user is asked for permission.

When scrolling through grid view of photos quickly app crashes due to excessive memory.
Numerous memory warnings are displayed while scrolling through photos.

This also happens in the provided example.

I would like to have the ability to brand the checkmark. So maybe create the checkmark in code that you can override the color. Thanks for considering this feature.

Error:

Fatal Exception: NSInternalInconsistencyException
attempt to delete and reload the same index path (<NSIndexPath: 0xc000000000200016> {length = 2, path = 0 - 1})

code i used to fix (in - (void)photoLibraryDidChange:(PHChange *)changeInstance):

NSIndexSet *changedIndexes = [collectionChanges changedIndexes]; // make sure that a changed index hasn't been deleted in the meantime // (for example by a user deleting a photo in Photos app) NSMutableIndexSet *changedIndexes2 = [NSMutableIndexSet new]; [changedIndexes enumerateIndexesUsingBlock:^(NSUInteger idx, BOOL * _Nonnull stop) { [removedIndexes enumerateIndexesUsingBlock:^(NSUInteger idx2, BOOL * _Nonnull stop2) { if (idx != idx2) { [changedIndexes2 addIndex:idx]; } }]; }]; if ([changedIndexes2 count]) { [collectionView reloadItemsAtIndexPaths:[changedIndexes2 aapl_indexPathsFromIndexesWithSection:0]]; }

Something to the effect of:

picker.autoDisableDoneButton = false

Check number of items in collections and don't display them in albums list if empty. Another idea is to add customisable delegate method so user can set the condition to display or not albums (maybe he don't want to display X album, or empty albums, or albums with less than X items, etc...)

Using cocoapod to install GMImagePicker, it works except the resources are missing. e.g. "Done" button is shown as "picker.navigation.done-button"

If not using cocoapod, and directly copy GMImagePicker into project, the resources are working properly, so looks like it's related to cocoapod only.

As you can see the title,
I'd like to set a limit(maximum) number for selecting photos.
Thanks,

Theres is an error poping up while pod install

Looks like a copy and paste issue of a comment from below.

From the file:

/**
 *  Determines whether or not the number of assets is shown in the Album list.
 *  The number of assets is visible by default.
 */
@property (nonatomic, strong) NSArray* customSmartCollections;

...

/**
 *  Determines whether or not the number of assets is shown in the Album list.
 *  The number of assets is visible by default.
 */
@property (nonatomic, assign) BOOL displayAlbumsNumberOfAssets;

The first one should be changed to reflect the property, I'm not super familiar or I'd submit a pull request. Maybe I can try to help later this week.

when I don't allow to access "Photo" and click the back button , the exception was throw, I have seen some of the other people's similar access to the album code, and not because there is no access to the right and wrong, but also did not see the judgment of the code,I need some help ，thank ！

Is there a way I could show the albums synced from the computer?